Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Message-ID: <835226024.1207734205468.JavaMail.jira@brutus>
Date: Wed, 9 Apr 2008 02:43:25 -0700 (PDT)
From: "Stefan Guggisberg (JIRA)" <jira@apache.org>
To: dev@jackrabbit.apache.org
Subject: [jira] Commented: (JCR-1526) Various improvment to Path and
 PathImpl
In-Reply-To: <1636590447.1207667364389.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/JCR-1526?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D125871=
15#action_12587115 ]=20

Stefan Guggisberg commented on JCR-1526:
----------------------------------------

thanks, michi!

i quickly browsed through the patch, looks good.

however, i've got one minor issue:=20

if i interpret the code changes in PathFactoryImpl$Path#getNormalizedPath()=
=20
correctly the following call would succeed where it currently throws an exc=
eption:

NameResolver nameResolver =3D ...
PathResolver pathResolver =3D new ParsingPathResolver(PathFactoryImpl.getIn=
stance(),
        nameResolver);
...
pathResolver.getQPath("/..").getNormalizedPath();

according to the javadoc of Path#getNormalizedPath it should throw an excep=
tion.

furthermore, i might be wrong but i think that it is still possible to crea=
te=20
syntactically incorrect paths using PathFactoryImpl (JCR-1409), e.g.

PathFactory pf =3D PathFactoryImpl.getInstance();=20
Path.Element re =3D pf.getRootElement();=20
Path illegalPath =3D pf.create(new Path.Element[]{re, re});=20

i would expect that Path objects always represent syntactically correct pat=
hs.

=20

> Various improvment to Path and PathImpl
> ---------------------------------------
>
>                 Key: JCR-1526
>                 URL: https://issues.apache.org/jira/browse/JCR-1526
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-spi, jackrabbit-spi-commons
>            Reporter: Michael D=C3=BCrig
>         Attachments: JCR-1526.patch
>
>
> There are various issues with Path and PathImpl which the following patch=
 addresses:
> - Fixed problem with normalization of some paths in PathImpl.=20
> - Fixed handling of relative paths in PathImpl.=20
> - Fixed wrong return value for depth and ancestor count in PathImpl.=20
> - Added method for determining equivalence of paths in PathImpl.
> - Fixed subPath method in PathImpl.=20
> - Clarified blurry contract for Path.
> - Added many new test cases
> For many of the fixes credits are due to Angela.

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.