From dev-return-18190-apmail-jackrabbit-dev-archive=jackrabbit.apache.org@jackrabbit.apache.org Wed Apr 16 15:08:34 2008 Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 77276 invoked from network); 16 Apr 2008 15:08:34 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 16 Apr 2008 15:08:34 -0000 Received: (qmail 79893 invoked by uid 500); 16 Apr 2008 15:08:31 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 79864 invoked by uid 500); 16 Apr 2008 15:08:31 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 79849 invoked by uid 99); 16 Apr 2008 15:08:31 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Apr 2008 08:08:31 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Apr 2008 15:07:47 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id C6AD1234C0D3 for ; Wed, 16 Apr 2008 08:05:22 -0700 (PDT) Message-ID: <1786223667.1208358322812.JavaMail.jira@brutus> Date: Wed, 16 Apr 2008 08:05:22 -0700 (PDT) From: "Julian Reschke (JIRA)" To: dev@jackrabbit.apache.org Subject: [jira] Commented: (JCR-1513) RepositoryService.checkin should return information about newly created version In-Reply-To: <81296125.1207130185641.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JCR-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12589591#action_12589591 ] Julian Reschke commented on JCR-1513: ------------------------------------- Proposal: 1) Allow checkin to return a NodeId *or* null (for easier migration of existing SPI impls) 2) Use the non-null return value in JCR2SPI to avoid fetching the base version. Then finally: 3) Get rid of the support for null return values. > RepositoryService.checkin should return information about newly created version > ------------------------------------------------------------------------------- > > Key: JCR-1513 > URL: https://issues.apache.org/jira/browse/JCR-1513 > Project: Jackrabbit > Issue Type: Improvement > Components: jackrabbit-spi > Reporter: Julian Reschke > Assignee: Julian Reschke > > We have a mismatch between Node.checkin(), which returns a new Version object, and RepositoryService.checkin(), which returns void. > Client of SPI, such as JCR2SPI, thus will have to make an additional request for the base version property, with the obvious drawbacks (another call, and a potential cause for a race condition). > Proposal: change the return code to NodeId. > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.