jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Guggisberg (JIRA)" <j...@apache.org>
Subject [jira] Reopened: (JCR-1471) Error when registering nodetype with same propdef as supertype
Date Thu, 13 Mar 2008 09:01:46 GMT

     [ https://issues.apache.org/jira/browse/JCR-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Stefan Guggisberg reopened JCR-1471:
------------------------------------


sorry, but i don't agree with the issue at hand.

there's IMO nothing wrong with the check:

during the merge of node type definitions (e.g. in order to 
resolve node type inheritance) the specified snippet of
code checks whether 2 property definitions with the same name
also have the same required type and multiValue flag.

if that's the case an exception is thrown since the 2 definitions 
would be ambiguous. name, required type and multiValue flags
are used as discriminators when choosing an appropriate property 
definition on a Node#setProperty call.

i suggest to resolve this issue as Invalid and revert the associated svn commit. 
  

> Error when registering nodetype with same propdef as supertype
> --------------------------------------------------------------
>
>                 Key: JCR-1471
>                 URL: https://issues.apache.org/jira/browse/JCR-1471
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: nodetype
>    Affects Versions: 1.4, core 1.4.1
>            Reporter: Tobias Bocanegra
>            Assignee: Tobias Bocanegra
>             Fix For: 1.5
>
>
> error in check:
>                                 if (pd.getRequiredType() == epd.getRequiredType()
>                                         && pd.isMultiple() == epd.isMultiple())
{
>                                     // conflict
>                                     String msg = "The property definition for '"
>                                             + name + "' in node type '"
>                                             + def.getDeclaringNodeType()
>                                             + "' conflicts with node type '"
>                                             + existingDef.getDeclaringNodeType()
>                                             + "': ambiguous property definition";
>                                     log.debug(msg);
>                                     throw new NodeTypeConflictException(msg);
>                                 }
> if needs to be inverted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message