jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Mueller (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-1452) Make use of jackrabbit.test.scale in test cases
Date Wed, 05 Mar 2008 13:43:40 GMT

    [ https://issues.apache.org/jira/browse/JCR-1452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575339#action_12575339
] 

Thomas Mueller commented on JCR-1452:
-------------------------------------

> What does scale=1 mean?

scale=1 means 'mvn package, run quickly'
scale=100 means 'nightly build, run as long as required, preferably less than 5 minutes'
We could also use a boolean flag 'nightlyBuild' if you prefer that (see below).

> those tests to share code for example in a common base class

I would implement only _one_ test case:
int max = 20000 + 5000000*(getTestScale()-1);
for(int len=0; len<=max; len*=2) {
  testWith(len);
}
Or, when using a boolean flag (less 'scalable' but easier to understand):
int max = getTestSize(20000, 500 * 1000000);
int getTestSize(int sizeWhenRunAsMvnPackage, int sizeWhenRunAsNightlyBuild)

> blindly scaling existing tests

That was not my plan. I would only touch existing tests where it really makes sense (if they
take too long for example).

> all the tests in it (jackrabbit-jcr-tests) are run per each "mvn install"

I think tests should be in the same project as the code (jackrabbit-core for the core and
so on) where possible. Do people actually run "mvn install" on jackrabbit-jcr-tests when changing
the jackrabbit-core? I didn't so far. (please don't missunderstand this as 'I would like to
move existing TCK tests to jackrabbit-core').

> test coverage tool

I fully agree.


> Make use of jackrabbit.test.scale in test cases
> -----------------------------------------------
>
>                 Key: JCR-1452
>                 URL: https://issues.apache.org/jira/browse/JCR-1452
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Marcel Reutegger
>            Priority: Minor
>             Fix For: 1.5
>
>
> There are already a number of longer running test cases in jackrabbit-core, but they
are all disabled because they otherwise make building jackrabbit-core a very long task.
> Those tests should make use of the jackrabbit.test.scale property and per default (scale
= 1) run within a short time.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message