jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Brosius (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-1423) [PATCH] fix clone implementation
Date Wed, 27 Feb 2008 19:15:51 GMT

    [ https://issues.apache.org/jira/browse/JCR-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573030#action_12573030
] 

Dave Brosius commented on JCR-1423:
-----------------------------------

That was really stupid on my part, my apologies. I will fix it and resubmit.

As an aside, i normally get all kinds of junit test failures, so i guess i didn't notice this.
Am i doing something wrong that these failures are happening?



> [PATCH] fix clone implementation
> --------------------------------
>
>                 Key: JCR-1423
>                 URL: https://issues.apache.org/jira/browse/JCR-1423
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core, jackrabbit-jcr2spi
>            Reporter: Dave Brosius
>            Priority: Trivial
>             Fix For: 1.5
>
>         Attachments: fix_clone_impl.patch
>
>
> Several classes implement clone, by doing new XXXX() to create the object. As these classes
aren't final, this will fail if these classes are ever derived from (which they are not, right
now). The correct implementation is to call super.clone(). This patch fixes this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message