jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Klimetschek (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-1419) Add test for database auto-reconnection
Date Wed, 27 Feb 2008 11:13:51 GMT

    [ https://issues.apache.org/jira/browse/JCR-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572873#action_12572873

Alexander Klimetschek commented on JCR-1419:

Hi Jukka, some justifications from my side (we developers always have to do that, don't we
;-) ):

- False alarm: Yupp, I needed to understand that as well. Actually it's those trial loops
that do the reconnect.

- autoReconnect: I wrote the test before backporting and ran it against the 1.3.3 code and
it failed. After backporting it worked. That is the reason why I spent some time writing this
test: I have no experience on the code I had to backport, because I haven't wrote any of it,
so I wanted to make sure there is a proper automatic test for it.

- Not running under windows: Any clues? Is it my external process that does not start? Or
the derby network server? If it is the first, it could be that he doesn't find the "java"
executable because it's not in the path.

- Complexity (external process vs. threaded):
a) I wanted to actually kill the process to simulate a harder connection loss.
b) And I thought one could re-use this external process setup for other performance and stability

Your threaded version does call "shutdown" on the network server, which allows for a normal
connection termination. Maybe one could kill the Thread, don't know if that works the same
as process killing. We could test both scenarios, normal connection shutdown and kill, we
don't know the internals of the derby client driver and how he behaves in both situations.
Otherwise it's true, your variant is slimmer.

> Add test for database auto-reconnection
> ---------------------------------------
>                 Key: JCR-1419
>                 URL: https://issues.apache.org/jira/browse/JCR-1419
>             Project: Jackrabbit
>          Issue Type: Test
>          Components: jackrabbit-core, test
>            Reporter: Alexander Klimetschek
>            Assignee: Jukka Zitting
>             Fix For: 1.5
>         Attachments: DatabaseConnectionFailureTest.java, jackrabbit-core.test-for-1400.patch
> Create a unit test for the database auto-reconnect feature (JCR-940).

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message