jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Brosius (JIRA)" <j...@apache.org>
Subject [jira] Updated: (JCR-1423) [PATCH] fix clone implementation
Date Thu, 28 Feb 2008 03:58:56 GMT

     [ https://issues.apache.org/jira/browse/JCR-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Dave Brosius updated JCR-1423:
------------------------------

    Attachment: fix_clone_impl.patch

Fix the boneheaded previous implementation of clone.


One point of note is that NodeTypeDef.clone does a shallow copy of member 'dependencies',
and so i left it that way. Was that intended?

Also note that the two clone's in core were incorrect as well.

Again my apologies

> [PATCH] fix clone implementation
> --------------------------------
>
>                 Key: JCR-1423
>                 URL: https://issues.apache.org/jira/browse/JCR-1423
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core, jackrabbit-jcr2spi
>            Reporter: Dave Brosius
>            Priority: Trivial
>             Fix For: 1.5
>
>         Attachments: fix_clone_impl.patch, fix_clone_impl.patch
>
>
> Several classes implement clone, by doing new XXXX() to create the object. As these classes
aren't final, this will fail if these classes are ever derived from (which they are not, right
now). The correct implementation is to call super.clone(). This patch fixes this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message