jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Klimetschek (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-1428) Add API for selective bundle consistency check (Jackrabbit-specific)
Date Fri, 29 Feb 2008 19:34:51 GMT

    [ https://issues.apache.org/jira/browse/JCR-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573919#action_12573919
] 

Alexander Klimetschek commented on JCR-1428:
--------------------------------------------

Had some trouble to actually trigger a problem in the JCR API with a child node entry pointing
to a missing node.

> session.getRootNode().getNode("fruits").getNode("bananas");

throws a PathNotFoundException (which is IMHO correct)

> session.getRootNode().getNode("fruits/bananas");

throws "javax.jcr.RepositoryException: failed to retrieve state of intermediary node: 39d2c699-0dad-4b27-aabd-0437913b5339:
39d2c699-0dad-4b27-aabd-0437913b5339" (which should be a PathNotFoundException, hence the
consistency check + fix)

Caused by: org.apache.jackrabbit.core.state.NoSuchItemStateException: 03679565-9b2b-4602-9030-1ac2e2e324a4
	at org.apache.jackrabbit.core.state.SessionItemStateManager.getItemState(SessionItemStateManager.java:178)
	at org.apache.jackrabbit.core.HierarchyManagerImpl.getItemState(HierarchyManagerImpl.java:119)
	at org.apache.jackrabbit.core.HierarchyManagerImpl.resolvePath(HierarchyManagerImpl.java:266)
	at org.apache.jackrabbit.core.CachingHierarchyManager.resolvePath(CachingHierarchyManager.java:132)
	at org.apache.jackrabbit.core.HierarchyManagerImpl.resolvePath(HierarchyManagerImpl.java:266)
	at org.apache.jackrabbit.core.CachingHierarchyManager.resolvePath(CachingHierarchyManager.java:132)
	at org.apache.jackrabbit.core.HierarchyManagerImpl.resolvePath(HierarchyManagerImpl.java:202)
	... 23 more

This could also be fixed by simply throwing a PathNotFoundEx in HierarchyManagerImpl.resolvePath(Path
path, ItemId id, int next) instead of a RepositoryEx when a NoSuchItemStateEx is catched there.
This would be more consistent.

Otherwise there are probably various complicated scenarios when the child node entry in the
underlying database "breaks" during runtime and exceptions pop up everywhere. Are there any
typical error.log examples?



> Add API for selective bundle consistency check (Jackrabbit-specific)
> --------------------------------------------------------------------
>
>                 Key: JCR-1428
>                 URL: https://issues.apache.org/jira/browse/JCR-1428
>             Project: Jackrabbit
>          Issue Type: New Feature
>          Components: jackrabbit-core
>            Reporter: Alexander Klimetschek
>             Fix For: 1.3.4
>
>
> Add a jackrabbit-specific API for doing a selective consistencyCheck, ie. on single nodes.
The current entire-workspace check can be very slow if there workspace is large enough. Also
it should be easy to write a tool to invoke that feature programmatically rather than by configuration
+ restart (see below).
> Existing Implementation:
> The current bundle consistencyCheck feature is enabled by setting a bundle PM parameter
and restarting Jackrabbit, it will then run upon startup (see JCR-972 for the only issue regarding
bundle consistency check). This check looks for broken parent-child relationships, ie. it
will remove any child node entries that reference non-existing parent nodes. For non-existing
parent UUIDs and other problems in bundles it will log those.
> Outlook:
> An advanced consistencyCheck could also check for non-existing version nodes and vice-versa
(see JCR-630), but this is not the focus of this issue and could be a later addition to the
API.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message