Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 11359 invoked from network); 23 Nov 2007 11:32:05 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 23 Nov 2007 11:32:05 -0000 Received: (qmail 5792 invoked by uid 500); 23 Nov 2007 11:31:51 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 5752 invoked by uid 500); 23 Nov 2007 11:31:51 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 5743 invoked by uid 99); 23 Nov 2007 11:31:51 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Nov 2007 03:31:51 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Nov 2007 11:31:49 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 6A8A371420E for ; Fri, 23 Nov 2007 03:31:43 -0800 (PST) Message-ID: <12160308.1195817503434.JavaMail.jira@brutus> Date: Fri, 23 Nov 2007 03:31:43 -0800 (PST) From: "Stefan Guggisberg (JIRA)" To: dev@jackrabbit.apache.org Subject: [jira] Commented: (JCR-1232) Merge UUID to NodeId In-Reply-To: <8520039.1195783483270.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544988 ] Stefan Guggisberg commented on JCR-1232: ---------------------------------------- nice! +1 for jukka's patch > Merge UUID to NodeId > -------------------- > > Key: JCR-1232 > URL: https://issues.apache.org/jira/browse/JCR-1232 > Project: Jackrabbit > Issue Type: Improvement > Components: jackrabbit-core > Reporter: Jukka Zitting > Priority: Minor > Attachments: nodeid.patch > > > The current NodeId class is mostly just a wrapper around UUID, which causes two objects to be instantiated for each node identifier that the system uses. The memory and processing overhead is quite small, but given that there are tons of NodeId instances it would be good to eliminate that overhead. > There is also lots of code that just converts UUIDs to NodeIds and vice versa. We could simplify such code if we just used NodeId everywhere. > Also, we might want to open up the possibility of using non-UUID node identifiers at some point in future, so it would make a lot of sense to remove the NodeId.getUUID method and rely directly on NodeId and it's equals(), hashCode(), and toString() methods in many places where we currently use UUIDs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.