Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Message-ID: <1172874.1194943492456.JavaMail.jira@brutus>
Date: Tue, 13 Nov 2007 00:44:52 -0800 (PST)
From: "angela (JIRA)" <jira@apache.org>
To: dev@jackrabbit.apache.org
Subject: [jira] Commented: (JCR-1212) JCR2SPI Node.hasProperty(String)
 "optional property incompatibility" with Jeceira
In-Reply-To: <30725608.1194813890627.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/JCR-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542069 ] 

angela commented on JCR-1212:
-----------------------------

PropertyNotFoundException ? PathNotFoundException ?
i don't know of a PropertyNotFoundException within jsr 170.

please be consistent.
and please provide a test case that illustrates the problem and shows that your proposal has an effect.

from what i remember, the itemstatefactory implementation deal with the PathNotFoundException (and throw ItemNotFoundException.

thus: i can't follow you again.... :(

> JCR2SPI Node.hasProperty(String) "optional property incompatibility" with Jeceira
> ---------------------------------------------------------------------------------
>
>                 Key: JCR-1212
>                 URL: https://issues.apache.org/jira/browse/JCR-1212
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: SPI
>    Affects Versions: 1.4
>         Environment: 1.4-SNAPSHOT
>            Reporter: David Rauschenbach
>            Priority: Minor
>
> Jeceira throws a PropertyNotFoundException when an SPI2JCR-wrapped Jeceira repository gets invoked with the SPI getPropertyInfo, specifying an optional property that does not exist for a given node instance.
> JCR2SPI only expects an ItemNotFoundException to be thrown in such a case, which prevents Node.hasProperty(String) from returning true/false, and instead results in a RepositoryException being thrown, which in effect is an interoperability issue.
> JCR2SPI compatibility with Jeceira-based repositories would be significantly improved if the code in NodeEntryImpl.java:loadPropertyEntry(PropertyId) caught not only ItemNotFoundException, but also PathNotFoundException, before returning null in both cases.
> Proposed change to NodeEntryImpl.java:
>     private PropertyEntry loadPropertyEntry(PropertyId childId) throws RepositoryException {
>         try {
>             PropertyState state = factory.getItemStateFactory().createDeepPropertyState(childId, this);
>             return (PropertyEntry) state.getHierarchyEntry();
>         } catch (ItemNotFoundException e) {
>             return null;
>         } catch (PathNotFoundException e) { <-- new
>             return null; <-- new
>         }
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.