Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Message-ID: <116908.1196272304170.JavaMail.jira@brutus>
Date: Wed, 28 Nov 2007 09:51:44 -0800 (PST)
From: "Przemo Pakulski (JIRA)" <jira@apache.org>
To: dev@jackrabbit.apache.org
Subject: [jira] Issue Comment Edited: (JCR-1242) Improve serialization of
 NodeReferences for BundleDB PMs
In-Reply-To: <19171384.1196253643020.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/JCR-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12546316 ] 

ppakulski edited comment on JCR-1242 at 11/28/07 9:51 AM:
----------------------------------------------------------------

thanks for the review stefan :

>- the serialization format used by ItemStateBinding is changed, but the
>  changes are *not* backwards compatible (see read/writePropertyId(...)). 

read/writePropertyIds methods have not been ever used, there is no need to ensure backward compatibility thenIte

> - version of new serialization format is not incremented/persisted 

yes it is, only method affected is writeState(DataOutputStream out, NodeReferences state), first byte contains new version (if new format wouldn't be persistent I couldn't use this solution)

>- the proposed changes are IMO rather 'hacky'; for example
>  ItemStateBinding#readState(..., NodeReferencesId, ...) assumes
>  implementation details of Serializer#serialize(NodeReferences refs, ...) 

that's true, but to ensure 'backward compatibility' for bundle PMs readState method must assume something :-), it assumes previous implementation, what do you suggest ?


      was (Author: ppakulski):
    thanks for the review stefan :

>- the serialization format used by ItemStateBinding is changed, but the
>  changes are *not* backwards compatible (see read/writePropertyId(...)). 

read/writePropertyIds methods have not been ever used, there is no need to ensure backward compatibility thenIte

> - version of new serialization format is not incremented/persisted 

yes it is, only method affected is writeState(DataOutputStream out, NodeReferences state), first byte contains new version (if new format wouldn't be persistent I couldn't used this solution)

>- the proposed changes are IMO rather 'hacky'; for example
>  ItemStateBinding#readState(..., NodeReferencesId, ...) assumes
>  implementation details of Serializer#serialize(NodeReferences refs, ...) 

that's true, but to ensure 'backward compatibility' for bundle PMs readState method must assume sumothing :-), it assumes previous implementation, what do you suggest ?


> Improve serialization of NodeReferences for BundleDB PMs
> --------------------------------------------------------
>
>                 Key: JCR-1242
>                 URL: https://issues.apache.org/jira/browse/JCR-1242
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: 1.3.3, 1.4
>            Reporter: Przemo Pakulski
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: JCR-1242.patch
>
>
> BudleDB PMs use currently Serializer class to serialize, deserialize node references. Those methods are unefficient, it use string representation of UUID, namespaceURI and localName. 
> For UUID rawBytes should be used and for namespaceURI, localName namespaceIndex/nameIndex should be used to improve efficiency of serialization/deserialization.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.