jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Przemo Pakulski (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-1242) Improve serialization of NodeReferences for BundleDB PMs
Date Wed, 28 Nov 2007 17:51:43 GMT

    [ https://issues.apache.org/jira/browse/JCR-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12546316
] 

Przemo Pakulski commented on JCR-1242:
--------------------------------------

thanks for the review stefan :

>- the serialization format used by ItemStateBinding is changed, but the
>  changes are *not* backwards compatible (see read/writePropertyId(...)). 

read/writePropertyIds methods have not been ever used, there is no need to ensure backward
compatibility thenIte

> - version of new serialization format is not incremented/persisted 

yes it is, only method affected is writeState(DataOutputStream out, NodeReferences state),
first byte contains new version (if new format wouldn't be persistent I couldn't used this
solution)

>- the proposed changes are IMO rather 'hacky'; for example
>  ItemStateBinding#readState(..., NodeReferencesId, ...) assumes
>  implementation details of Serializer#serialize(NodeReferences refs, ...) 

that's true, but to ensure 'backward compatibility' for bundle PMs readState method must assume
sumothing :-), it assumes previous implementation, what do you suggest ?






> Improve serialization of NodeReferences for BundleDB PMs
> --------------------------------------------------------
>
>                 Key: JCR-1242
>                 URL: https://issues.apache.org/jira/browse/JCR-1242
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: 1.3.3, 1.4
>            Reporter: Przemo Pakulski
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: JCR-1242.patch
>
>
> BudleDB PMs use currently Serializer class to serialize, deserialize node references.
Those methods are unefficient, it use string representation of UUID, namespaceURI and localName.

> For UUID rawBytes should be used and for namespaceURI, localName namespaceIndex/nameIndex
should be used to improve efficiency of serialization/deserialization.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message