jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jukka Zitting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-1232) Merge UUID to NodeId
Date Fri, 23 Nov 2007 11:54:42 GMT

    [ https://issues.apache.org/jira/browse/JCR-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544996
] 

Jukka Zitting commented on JCR-1232:
------------------------------------

> Sorry, I really prefer having only one copy of the UUID code. It doesn't matter to me
in what class that is,
> but copying the source code is not an option for me; that would be -1. 

I was contemplating removing or deprecating the UUID class, but it being a jackrabbit-jcr-commons
class I'm not sure how widely it is used outside jackrabbit-core.

In any case I think the duplication of code in this case is really trivial (the most complex
parts I'm duplicating are two if statements and a number of trivial bit shifts), so I think
the benefits should outweight concerns over duplication.

> Merge UUID to NodeId
> --------------------
>
>                 Key: JCR-1232
>                 URL: https://issues.apache.org/jira/browse/JCR-1232
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Jukka Zitting
>            Priority: Minor
>         Attachments: nodeid.patch
>
>
> The current NodeId class is mostly just a wrapper around UUID, which causes two objects
to be instantiated for each node identifier that the system uses. The memory and processing
overhead is quite small, but given that there are tons of NodeId instances it would be good
to eliminate that overhead.
> There is also lots of code that just converts UUIDs to NodeIds and vice versa. We could
simplify such code if we just used NodeId everywhere.
> Also, we might want to open up the possibility of using non-UUID node identifiers at
some point in future, so it would make a lot of sense to remove the NodeId.getUUID method
and rely directly on NodeId and it's equals(), hashCode(), and toString() methods in many
places where we currently use UUIDs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message