Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Received-SPF: pass (athena.apache.org: domain of thomas.tom.mueller@gmail.com
 designates 64.233.166.180 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=PYAroUK547X4CthPdY501vaAEhUxXSR1Pe82l12gx3V3uPfK+qLy3XhU6B2bWZPmz+seOU4vPTawyuJ6621beTFr+CWuCXgEgK+0+Or8CKzAC5Nk3VWT8f1CWGCvko/OCsuGr/hIknBIFYAs/GdW/od/eKL6Ocd6d6VJvQs8O98=
Message-ID: <5f211bd50709200508n30dee319t6f0f328eeb96ba97@mail.gmail.com>
Date: Thu, 20 Sep 2007 14:08:41 +0200
From: "Thomas Mueller" <thomas.tom.mueller@gmail.com>
To: dev@jackrabbit.apache.org
Subject: Re: [jira] Commented: (JCR-940) add db connection autoConnect for
 BundleDbPersistenceManager.
In-Reply-To: <24637666.1190289031249.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <14540291.1180021276911.JavaMail.jira@brutus>
	 <24637666.1190289031249.JavaMail.jira@brutus>

Hi,

> I think that besides the BundleDbPM.store method
> the ConnectionrecoveryManager.execute* methods
> also need to be wrapped by a retry-loop.

I think you are right, those methods should loop as well (except when
autoReconnect is false).

> I've patched this locally and want to execute the unit tests using the MSSQL bundle PM. I'm not familiar with the test harness...how should I do this? Some initial attempts to alter the repository.xml and workspace.xmls in the jackrabbit-core\applications\test directory failed.

It's a bit tricky: you need to change repository.xml (2 places) and in
both workspace.xml files (1 place each). I have used:

repository.xml / Workspace

        <PersistenceManager
class="org.apache.jackrabbit.core.persistence.bundle.PostgreSQLPersistenceManager">
          <param name="url" value="jdbc:postgresql://localhost/test"/>
          <param name="blockOnConnectionLoss" value="true"/>
          <param name="schemaObjectPrefix" value="${wsp.name}_"/>
          <param name="user" value="..."/>
          <param name="password" value="..."/>
        </PersistenceManager>

repository.xml / Versioning

        <PersistenceManager
class="org.apache.jackrabbit.core.persistence.bundle.PostgreSQLPersistenceManager">
          <param name="url" value="jdbc:postgresql://localhost/test"/>
          <param name="blockOnConnectionLoss" value="true"/>
          <param name="schemaObjectPrefix" value="version_"/>
          <param name="user" value="..."/>
          <param name="password" value="..."/>
        </PersistenceManager>

workspaces/*/workspace.xml:

        <PersistenceManager
class="org.apache.jackrabbit.core.persistence.bundle.PostgreSQLPersistenceManager">
          <param name="url" value="jdbc:postgresql://localhost/test"/>
          <param name="blockOnConnectionLoss" value="true"/>
     <param name="schemaObjectPrefix" value="${wsp.name}_"/>
          <param name="user" value="..."/>
          <param name="password" value="..."/>
  </PersistenceManager>

I have multiple configurations (copies of the applications/test
directory). Before running the build I just replace the files with the
configuration (simple db, bundle db, data store) I want to test. I
think it would be great if the unit test could be run against each
configurations one after the other - but I don't know how this can be
automated using JUnit / Maven.

Thomas

>
> > add db connection autoConnect for BundleDbPersistenceManager.
> > -------------------------------------------------------------
> >
> >                 Key: JCR-940
> >                 URL: https://issues.apache.org/jira/browse/JCR-940
> >             Project: Jackrabbit
> >          Issue Type: Improvement
> >          Components: core
> >    Affects Versions: 1.3
> >            Reporter: Xiaohua Lu
> >         Attachments: JCR-940-v2.patch, JCR-940-v3.patch, JCR-940.patch
> >
> >
> > Since bundled db pm doesn't inherited from database pm, it can't reconnect once database is bounced. it would be nice to add this feature.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>