Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Received-SPF: pass (athena.apache.org: domain of christophe.lombart@gmail.com
 designates 209.85.128.184 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=bhEcd9Wohk3C1FRTfXoWdFvB6VXzdYOjBhy91Tlt6eJnXpOX9x86wrouIc4QFlVprW9Ng3cgofj8mqmpqZjxyUHqB62uDoWcpmRlVdmzQ0SqAQqJ5ep4/Tt6mpLQodPfTQ5f2MLEFNEPBt/xRXEyUNszgQy40URQ5x5/iUYTa2c=
Message-ID: <3b728ee90709112321q7257dcc9n466403916e30e487@mail.gmail.com>
Date: Wed, 12 Sep 2007 08:21:19 +0200
From: "Christophe Lombart" <christophe.lombart@gmail.com>
To: dev@jackrabbit.apache.org
Subject: Re: [OCM] SimpleFieldHelper emits alot of WARN messages
In-Reply-To: <1189576806.24859.50.camel@bslm-046.corp.day.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_21275_9967628.1189578079959"
References: <1189521905.24859.34.camel@bslm-046.corp.day.com>
	 <3b728ee90709111332xaeb61c7x312b7bf6d17d9abb@mail.gmail.com>
	 <1189576806.24859.50.camel@bslm-046.corp.day.com>

------=_Part_21275_9967628.1189578079959
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

You can apply the patch and after I will start the refactoting.

Thanks,
Christophe


On 9/12/07, Felix Meschberger <fmeschbe@gmail.com> wrote:
>
> Hi,
>
> Alright then, I will create the JIRA and try to setup a patch.
>
> Christophe, as you are currently refactoring the code, shall I just
> apply the patch or do you want to integrate this in your refactoring
> work ?
>
> Regards
> Felix
>
>
> Am Dienstag, den 11.09.2007, 22:32 +0200 schrieb Christophe Lombart:
> > On 9/11/07, Felix Meschberger <fmeschbe@gmail.com> wrote:
> > >
> > > Hi all,
> > >
> > > The SimpleFieldsHelper.retrieveSimpleField method is used to load JCR
> > > properties into "simple" fields. If a node does not have a mapped
> > > property, a warning message is emited. I am not sure, whether it is
> > > actually a problematic situation if a property, which is not mandatory
> > > does not exist ? In fact, if a property is mandatory, it may or may
> not
> > > exist and thus the mapping may be supplied or not.
> > >
> > > What do you think of lowering the severity of this situation to debug
> ?
> > > Alternatively (or in addition) the descriptor might be extended such
> > > that the mapping may declared as mandatory without rquiring the
> property
> > > to be mandatory or there might even be some default value specified or
> > > the SimpleFieldsHelper might access the property definition to see
> > > whether there is a default value defined ....
> >
> >
> >
> > +2  (+1 for the debug, +1 for the  changing a little bit the code and/or
> > the descriptor).
>
>

------=_Part_21275_9967628.1189578079959--