Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 41886 invoked from network); 28 Sep 2007 17:17:12 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 28 Sep 2007 17:17:12 -0000 Received: (qmail 20669 invoked by uid 500); 28 Sep 2007 17:17:01 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 20636 invoked by uid 500); 28 Sep 2007 17:17:01 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 20627 invoked by uid 99); 28 Sep 2007 17:17:01 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Sep 2007 10:17:01 -0700 X-ASF-Spam-Status: No, hits=-98.8 required=10.0 tests=ALL_TRUSTED,DNS_FROM_DOB,RCVD_IN_DOB X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Sep 2007 17:17:11 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 9E2EC71420E for ; Fri, 28 Sep 2007 10:16:50 -0700 (PDT) Message-ID: <29533727.1190999810589.JavaMail.jira@brutus> Date: Fri, 28 Sep 2007 10:16:50 -0700 (PDT) From: "Julian Reschke (JIRA)" To: dev@jackrabbit.apache.org Subject: [jira] Resolved: (JCR-1150) JCR2SPI: several performance improvements pointed out by Findbugs In-Reply-To: <31094575.1190981810556.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JCR-1150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved JCR-1150. --------------------------------- Resolution: Fixed Fixed newly broken code with revision 580427 (sorry!). > JCR2SPI: several performance improvements pointed out by Findbugs > ----------------------------------------------------------------- > > Key: JCR-1150 > URL: https://issues.apache.org/jira/browse/JCR-1150 > Project: Jackrabbit > Issue Type: Improvement > Components: SPI > Reporter: Julian Reschke > Assignee: Julian Reschke > Priority: Minor > > FindBug report: > M P Bx: Method org.apache.jackrabbit.jcr2spi.nodetype.BitsetENTCacheImpl.getBitNumber(QName) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead src/main/java/org/apache/jackrabbit/jcr2spi/nodetype BitsetENTCacheImpl.java line 177 1190981544656 1666284 > M P Bx: Method org.apache.jackrabbit.jcr2spi.query.RowIteratorImpl$RowImpl.getValue(String) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead src/main/java/org/apache/jackrabbit/jcr2spi/query RowIteratorImpl.java line 247 1190981544671 1666292 > M P Bx: Method org.apache.jackrabbit.jcr2spi.WorkspaceManager.onEventReceived(EventBundle[], InternalEventListener[]) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead src/main/java/org/apache/jackrabbit/jcr2spi WorkspaceManager.java line 616 1190981544640 1666279 > M P WMI: Method org.apache.jackrabbit.jcr2spi.name.NamespaceCache.syncNamespaces(Map) makes inefficient use of keySet iterator instead of entrySet iterator src/main/java/org/apache/jackrabbit/jcr2spi/name NamespaceCache.java line 193 1190981544656 1666283 > M P WMI: Method org.apache.jackrabbit.jcr2spi.nodetype.NodeTypeRegistryImpl.internalRegister(Map) makes inefficient use of keySet iterator instead of entrySet iterator src/main/java/org/apache/jackrabbit/jcr2spi/nodetype NodeTypeRegistryImpl.java line 524 1190981544656 1666285 > M P WMI: Method org.apache.jackrabbit.jcr2spi.observation.ObservationManagerImpl.onEvent(EventBundle) makes inefficient use of keySet iterator instead of entrySet iterator src/main/java/org/apache/jackrabbit/jcr2spi/observation ObservationManagerImpl.java line 189 1190981544656 1666286 > M P WMI: Method org.apache.jackrabbit.jcr2spi.state.NodeState.persisted(ChangeLog) makes inefficient use of keySet iterator instead of entrySet iterator src/main/java/org/apache/jackrabbit/jcr2spi/state NodeState.java line 275 1190981544671 1666297 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.