Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 5737 invoked from network); 12 Sep 2007 06:29:02 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 12 Sep 2007 06:29:02 -0000 Received: (qmail 91471 invoked by uid 500); 12 Sep 2007 06:28:54 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 91444 invoked by uid 500); 12 Sep 2007 06:28:54 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 91435 invoked by uid 99); 12 Sep 2007 06:28:54 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Sep 2007 23:28:54 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of fmeschbe@gmail.com designates 64.233.182.191 as permitted sender) Received: from [64.233.182.191] (HELO nf-out-0910.google.com) (64.233.182.191) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Sep 2007 06:30:26 +0000 Received: by nf-out-0910.google.com with SMTP id g16so93699nfd for ; Tue, 11 Sep 2007 23:28:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:subject:from:to:in-reply-to:references:content-type:date:message-id:mime-version:x-mailer:content-transfer-encoding; bh=xIzPwli+h4m/wyphPFRjnR0E3VBeueGBHqrVD5skB3c=; b=RmKhUi0FGFuoTiGeewbFK7RNtIgavMtrwwLr5/P0xqAIO4ZBpyejy9xmcks84NsQMcMSjnIlUHvHm9x2Xy2UjUq6fU81vBO4cyBSpvkijqknXN3mrSDCHn0ShtogzQWkdiK7i/6KxuWRv5zNQeSagXS9QSpWTzQfDu+W8V0iqpE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:subject:from:to:in-reply-to:references:content-type:date:message-id:mime-version:x-mailer:content-transfer-encoding; b=as+nO93qzMJl4uISELADm7vRh6ZVcR546vvp6+WKT16k+oR5Tka/BImMNDY7nkJxB5uccG7LDEL9CsesTxXuwhJea69Vj2tGT3unXZs6szgdkBeA+Y/r6fdmSPRN35m5n66mAohYC+ZB7jpVI2DYS+y9L/r1TW2hXcWC1/B96/A= Received: by 10.86.99.9 with SMTP id w9mr831844fgb.1189578509359; Tue, 11 Sep 2007 23:28:29 -0700 (PDT) Received: from ?192.168.1.109? ( [87.102.138.82]) by mx.google.com with ESMTPS id k29sm12240380fkk.2007.09.11.23.28.27 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 11 Sep 2007 23:28:28 -0700 (PDT) Subject: Re: [OCM] SimpleFieldHelper emits alot of WARN messages From: Felix Meschberger To: dev@jackrabbit.apache.org In-Reply-To: <3b728ee90709112321q7257dcc9n466403916e30e487@mail.gmail.com> References: <1189521905.24859.34.camel@bslm-046.corp.day.com> <3b728ee90709111332xaeb61c7x312b7bf6d17d9abb@mail.gmail.com> <1189576806.24859.50.camel@bslm-046.corp.day.com> <3b728ee90709112321q7257dcc9n466403916e30e487@mail.gmail.com> Content-Type: text/plain Date: Wed, 12 Sep 2007 08:28:26 +0200 Message-Id: <1189578506.24859.52.camel@bslm-046.corp.day.com> Mime-Version: 1.0 X-Mailer: Evolution 2.10.3 (2.10.3-2.fc7) Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org ok. Regards Felix Am Mittwoch, den 12.09.2007, 08:21 +0200 schrieb Christophe Lombart: > You can apply the patch and after I will start the refactoting. > > Thanks, > Christophe > > > On 9/12/07, Felix Meschberger wrote: > > > > Hi, > > > > Alright then, I will create the JIRA and try to setup a patch. > > > > Christophe, as you are currently refactoring the code, shall I just > > apply the patch or do you want to integrate this in your refactoring > > work ? > > > > Regards > > Felix > > > > > > Am Dienstag, den 11.09.2007, 22:32 +0200 schrieb Christophe Lombart: > > > On 9/11/07, Felix Meschberger wrote: > > > > > > > > Hi all, > > > > > > > > The SimpleFieldsHelper.retrieveSimpleField method is used to load JCR > > > > properties into "simple" fields. If a node does not have a mapped > > > > property, a warning message is emited. I am not sure, whether it is > > > > actually a problematic situation if a property, which is not mandatory > > > > does not exist ? In fact, if a property is mandatory, it may or may > > not > > > > exist and thus the mapping may be supplied or not. > > > > > > > > What do you think of lowering the severity of this situation to debug > > ? > > > > Alternatively (or in addition) the descriptor might be extended such > > > > that the mapping may declared as mandatory without rquiring the > > property > > > > to be mandatory or there might even be some default value specified or > > > > the SimpleFieldsHelper might access the property definition to see > > > > whether there is a default value defined .... > > > > > > > > > > > > +2 (+1 for the debug, +1 for the changing a little bit the code and/or > > > the descriptor). > > > >