jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martijn Hendriks" <marti...@gx.nl>
Subject RE: Validation in QName class
Date Mon, 17 Sep 2007 13:04:19 GMT
Hi Jukka,

> If you do need the extra functionality from NodeTypeRegistry, 
> how about if we exposed it on the JackrabbitNodeTypemanager 
> level together with proper name validation? This solution 
> would be cleaner design-wise and would allow you to drop one 
> direct jackrabbit-core dependency.

That would be great, should I create a JIRA issue for that?

In the category of "quick and dirty fixes": would the following change
to checkNamespace in the NodeTypeRegistry be a risky one? The
1.4-SNAPSHOT of a few minutes ago builds correctly.

Best wishes,

Martijn


@@ -1363,6 +1365,14 @@
         if (name != null) {
             // make sure namespace uri denotes a registered namespace
             nsReg.getPrefix(name.getNamespaceURI());
+            // check the format of the local name
+            if (!name.equals(ItemDef.ANY_NAME)){
+                try {
+                    NameFormat.checkFormat(name.getLocalName());
+                } catch (IllegalNameException e) {
+                    throw new RepositoryException("Invalid QName", e);
+                }
+            }
         }
     }

Mime
View raw message