jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Mueller (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-940) add db connection autoConnect for BundleDbPersistenceManager.
Date Fri, 14 Sep 2007 10:15:32 GMT

    [ https://issues.apache.org/jira/browse/JCR-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527442
] 

Thomas Mueller commented on JCR-940:
------------------------------------

Hi,

Great! The patch looks very good! 

I will apply it in my environment, test it, and then commit it. The 'blockOnConnectionLoss'
feature is OK, what is your use case? Just one remark: currently SLEEP_BEFORE_RECONNECT is
0.5 seconds, that's great because re-creating a TCP/IP connection usually is quick, no need
to wait many seconds before the first re-try (if we expect MySQL to be the 'customer' for
this feature). 

Currently TRIALS is 2, that means giving up after at most 1 second. I think that's a bit short.
What about setting TRIALS to 10? It will then try at most 5 seconds, enough for a unstable
wireless connection (not sure if this is a use case).

Thomas

> add db connection autoConnect for BundleDbPersistenceManager.
> -------------------------------------------------------------
>
>                 Key: JCR-940
>                 URL: https://issues.apache.org/jira/browse/JCR-940
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.3
>            Reporter: Xiaohua Lu
>         Attachments: JCR-940-v2.patch, JCR-940-v3.patch, JCR-940.patch
>
>
> Since bundled db pm doesn't inherited from database pm, it can't reconnect once database
is bounced. it would be nice to add this feature. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message