jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-1140) NodeId for root node should not be hardcoded in jcr2spi
Date Thu, 27 Sep 2007 14:30:50 GMT

    [ https://issues.apache.org/jira/browse/JCR-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530742
] 

angela commented on JCR-1140:
-----------------------------

> org.apache.jackrabbit.jcr2spi.hierarchy.NodeEntryImpl.getId() always returns idFactory.createNodeId((String)

> null, Path.ROOT) for the root node 

i think this is not true. this is only the case if the root entry does not have a uniqueID
defined.
the uniqueID gets set upon retrieval of the entry or of a child-entry, whose ItemID is composed
of the uniqueID of an ancestor and a path.

or do you mean a different thing?

from my point of view, the first issue you  describe (and the subject refers to) is not given
or at least it's a 
different issue.

for the second one (spi2jcr): that wrong. but can you please open a different issue for that?
 thanks
angela

> NodeId for root node should not be hardcoded in jcr2spi
> -------------------------------------------------------
>
>                 Key: JCR-1140
>                 URL: https://issues.apache.org/jira/browse/JCR-1140
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: SPI
>            Reporter: Michael Dürig
>
> org.apache.jackrabbit.jcr2spi.hierarchy.NodeEntryImpl.getId() always returns idFactory.createNodeId((String)
null, Path.ROOT) for the root node although a repository might want to reference the root
node by UUID. NodeId.getId() breaks the contract of org.apache.jackrabbit.spi.ItemId which
for this case states: "The item can not be identified with a unique ID and none of its ancestors
can be identified with a unique ID. The item is identified by an absolute path".
> I suggest to change the implementation such that when NodeId.getId() needs to return
the NodeId of the root node a round trip to org.apache.jackrabbit.spi.RepositoryService.getRootId()
is done. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message