jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Guggisberg (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-1050) Remove synchronization from JNDI data sources
Date Thu, 16 Aug 2007 15:39:31 GMT

    [ https://issues.apache.org/jira/browse/JCR-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520275

Stefan Guggisberg commented on JCR-1050:


thanks for the patch, i appreciate your efforts.

i have a few general comments regarding the patch:

- the patch is *huge* (>2k lines) and incorporates massive refactoring related 
  and other changes in several jackrabbit classes;  this makes tracking and 
  understanding the actual changes very difficult at best. 

- the subject of this issue suggests that only JNDI datasource related classes 
  would be affected ('Remove synchronization from JNDI data sources'). the scope
  of the patch is much broader as far as i can tell from browsing through the diff.

- the patch is incomplete; i wasn't able to apply it because of some missing files.

rather than refactoring the current implementations i'd like to encourage you to 
write a separate, independant persistence manager (accepting some code 
redundancy). that would enable us to perform one-to-one performance, functional 
& scalability tests. the test results would provide a better basis for decision-making.

without such tests we can only guess and make assumptions.


> Remove synchronization from JNDI data sources
> ---------------------------------------------
>                 Key: JCR-1050
>                 URL: https://issues.apache.org/jira/browse/JCR-1050
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: core
>            Reporter: Padraic Hannon
>         Attachments: JNDI_Datasource_Changes.diff
> Using datasources one should be able to rely on the application server to manage PreparedStatement
caches therefore pre-creating and holding onto the connection for long periods of time should
not be needed. This relates to improvement JCR-313, however, that change did not address the
benefits one could see in using an application server controlled datasource. Even if jackrabbit
does aim to use an embedded database such a system could be configured to use datasources
and could benefit from the removal of the synchronization. 

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message