[ https://issues.apache.org/jira/browse/JCR-1071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524026
]
angela commented on JCR-1071:
-----------------------------
the reason for denying importProperties for the DefaultHandler was, that its default nodetype
(nt:folder) does not allow for any properties to be modified or removed.
however, i agree that the default handler should at least try to import properties, specially
since the default node types can be changed.
> PROPPATCH on collection gets 403 Forbidden
> ------------------------------------------
>
> Key: JCR-1071
> URL: https://issues.apache.org/jira/browse/JCR-1071
> Project: Jackrabbit
> Issue Type: Bug
> Components: webdav
> Affects Versions: 1.4
> Reporter: Rob Owen
> Assignee: angela
> Fix For: 1.4
>
>
> DefaultHandler.canImport(PropertyImportContext, boolean) prevents setting properties
(PROPPATCH) on collections through WebDAV ... returns 403 Forbidden. It checks to see whether
the contextItem is not a collection, or has a jcr:content node. This test fails for a collection
and should probably allow collections or nodes that have a jcr:content subnode. Here is a
patch for the change
> Index: jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/server/io/DefaultHandler.java
> ===================================================================
> --- jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/server/io/DefaultHandler.java
(revision 567695)
> +++ jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/server/io/DefaultHandler.java
(working copy)
> @@ -570,7 +570,7 @@
> }
> Item contextItem = context.getImportRoot();
> try {
> - return contextItem != null && contextItem.isNode() && (!isCollection
|| ((Node)contextItem).hasNode(JcrConstants.JCR_CONTENT));
> + return contextItem != null && contextItem.isNode() && (isCollection
|| ((Node)contextItem).hasNode(JcrConstants.JCR_CONTENT));
> } catch (RepositoryException e) {
> log.error("Unexpected error: " + e.getMessage());
> return false;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
|