Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 48709 invoked from network); 26 Jun 2007 17:19:51 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 26 Jun 2007 17:19:51 -0000 Received: (qmail 20464 invoked by uid 500); 26 Jun 2007 17:19:52 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 20438 invoked by uid 500); 26 Jun 2007 17:19:52 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 20420 invoked by uid 99); 26 Jun 2007 17:19:52 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jun 2007 10:19:52 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jun 2007 10:19:47 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 30055714062 for ; Tue, 26 Jun 2007 10:19:26 -0700 (PDT) Message-ID: <2198103.1182878366194.JavaMail.jira@brutus> Date: Tue, 26 Jun 2007 10:19:26 -0700 (PDT) From: "Bertrand Delacretaz (JIRA)" To: dev@jackrabbit.apache.org Subject: [jira] Updated: (JCR-984) [PATCH] Make DocViewImportHandler more robust against broken Attributes.getURI() method In-Reply-To: <33407772.1182875605996.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JCR-984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated JCR-984: ------------------------------------ Priority: Trivial (was: Major) > [PATCH] Make DocViewImportHandler more robust against broken Attributes.getURI() method > --------------------------------------------------------------------------------------- > > Key: JCR-984 > URL: https://issues.apache.org/jira/browse/JCR-984 > Project: Jackrabbit > Issue Type: Improvement > Components: core > Affects Versions: 1.3.1 > Reporter: Bertrand Delacretaz > Priority: Trivial > Attachments: DocViewImportHandler.patch > > > DocViewImportHandler throws NullPointerException when the XML parser (incorrectly) returns null for the Attributes.getURI() call. > This small patch makes it more robust against this. > Whether this is a good idea is debatable - failing loudly on a broken parser might be more desirable - let's see what people think. > The problem happened during testing when an old version of the XPP parser (http://www.extreme.indiana.edu/xgws/xsoap/xpp/) found its way in our webapp's war file (pull-parser-2.jar, md5sum=1a1a909825c1bfd9b0cdfa3b29969438). > It might be useful to log some info about which parser is being used, I'll see if I can contribute something for this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.