Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 77648 invoked from network); 25 Jun 2007 08:59:49 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 25 Jun 2007 08:59:49 -0000 Received: (qmail 53721 invoked by uid 500); 25 Jun 2007 08:59:50 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 53689 invoked by uid 500); 25 Jun 2007 08:59:50 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 53674 invoked by uid 99); 25 Jun 2007 08:59:50 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Jun 2007 01:59:50 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Jun 2007 01:59:46 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 77F217141EB for ; Mon, 25 Jun 2007 01:59:26 -0700 (PDT) Message-ID: <12029934.1182761966486.JavaMail.jira@brutus> Date: Mon, 25 Jun 2007 01:59:26 -0700 (PDT) From: "Marcel Reutegger (JIRA)" To: dev@jackrabbit.apache.org Subject: [jira] Resolved: (JCR-967) Only search the index for the "jcr:system" tree if needed In-Reply-To: <9891298.1181553206069.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JCR-967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger resolved JCR-967. ---------------------------------- Resolution: Fixed Fix Version/s: 1.4 > I didn't provide a default implementation of needsSystemTree() on purpose because I wanted > to force everyone extending QueryNode to think about if his implementation needs the system > tree or not. Ok, fair enough. Based on your ASF license grant on the patch I added a license header to PathQueryNodeTest, which was missing. I also added JavaDoc to the new method SearchIndex.getIndexReader(boolean) and opened up the visibility to protected. Thanks a lot for your work! Committed the patch in revision: 550419 > Only search the index for the "jcr:system" tree if needed > --------------------------------------------------------- > > Key: JCR-967 > URL: https://issues.apache.org/jira/browse/JCR-967 > Project: Jackrabbit > Issue Type: Improvement > Components: query > Affects Versions: 1.3 > Reporter: Christoph Kiehl > Fix For: 1.4 > > Attachments: patch.txt > > > Right now every time a query is executed the index of the current workspace as well as the index of the "jcr:system" tree is searched. A lot of queries are not searching in the "jcr:system" tree at all therefore it should be checked if the query contains paths that include "jcr:system". There are two relevant nodes in the query tree to find that out: > - what's the first location step and does it include the jcr:system tree? I think that's an easy one. > - does the query contain a jcr:deref node? If there is an intermediate result of a query may dereference into the jcr:system tree. > This should notably speed up query execution if you are working extensively with versioning. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.