jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christophe Lombart (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-922) jcr mapping layer (OCM) should expose lock owner
Date Mon, 04 Jun 2007 22:04:29 GMT

    [ https://issues.apache.org/jira/browse/JCR-922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501390
] 

Christophe Lombart commented on JCR-922:
----------------------------------------

Can you check the code ? 
I made the following modifications : 
1/ Review the method lock. Now, it returns a Lock object. 
2/ I added new unit tests. See the class PersistenceManagerLockTest. the test called "testLockWithNodeType"
uses an object containing the attribute lockowner. This attribute is null when the object
is not locked and not null when it is locked. 

Let me know if it match to your needs. Feel free to comment this issue. 





> jcr mapping layer (OCM) should expose lock owner
> ------------------------------------------------
>
>                 Key: JCR-922
>                 URL: https://issues.apache.org/jira/browse/JCR-922
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jcr-mapping
>            Reporter: ruchi goel
>            Assignee: Christophe Lombart
>             Fix For: 1.4
>
>
> jcr mapping layer 's  persistencemanager.java  does not expose an API for returning lockowner.
Ideally   , the following method 
> public String lock(final String absPath, final boolean isDeep, final boolean isSessionScoped)

> should return a hashmap/String array containing locktoken as well as lockowner. 
> I tried having lockowner as a field in my java object and mapping it to jcr:lockOwner
, so that I can just use getLockOwner() . But the problem is this property gets introduced
in the node only if  the node is locked. So, when I try to insert a node , before I can even
lock it , the insertion fails since there is no property like jcr:lockOwner   till then .

> So, I feel there is need for the above API. It is ok to have it exposed via separate
call in order to maintain backward compatability

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message