jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-984) [PATCH] Make DocViewImportHandler more robust against broken Attributes.getURI() method
Date Wed, 27 Jun 2007 07:16:26 GMT

    [ https://issues.apache.org/jira/browse/JCR-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508453
] 

angela commented on JCR-984:
----------------------------

i have the impression that the mentioned parser has more than one bug and i'm not sure, whether
we should start working around them. from my point of view (dev view) it is easier to find
the source of this kind of problem if the code fails ungracefully with runtime exception instead
of producing wrong results without complaining.

therefore i would prefer not to apply the patch as is.

however, adding some debug information about the parser used would for sure be useful for
all kind of support.

angela

> [PATCH] Make DocViewImportHandler more robust against broken Attributes.getURI() method
> ---------------------------------------------------------------------------------------
>
>                 Key: JCR-984
>                 URL: https://issues.apache.org/jira/browse/JCR-984
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.3.1
>            Reporter: Bertrand Delacretaz
>            Priority: Trivial
>         Attachments: DocViewImportHandler.patch
>
>
> DocViewImportHandler throws NullPointerException when the XML parser (incorrectly) returns
null for the Attributes.getURI() call.
> This small patch makes it more robust against this.
> Whether this is a good idea is debatable - failing loudly on a broken parser might be
more desirable - let's see what people think.
> The problem happened during testing when an old version of the XPP parser (http://www.extreme.indiana.edu/xgws/xsoap/xpp/)
found its way in our webapp's war file (pull-parser-2.jar, md5sum=1a1a909825c1bfd9b0cdfa3b29969438).
> It might be useful to log some info about which parser is being used, I'll see if I can
contribute something for this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message