jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Neale (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-863) Patch to use FileLock for locking instead of empty file
Date Sat, 26 May 2007 01:09:16 GMT

    [ https://issues.apache.org/jira/browse/JCR-863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12499269

Michael Neale commented on JCR-863:

I agree with Marcel. This is getting really nasty if we want to support from 1.4 through 1.6
(Java) in a non ugly fashion. Its also very hard to test. 

Perhaps the better solution is to make upgrading to Lucene 2.1 a priority, so this code (which
is lucene specific anyway) can be retired and this JIRA closed. 

> Patch to use FileLock for locking instead of empty file
> -------------------------------------------------------
>                 Key: JCR-863
>                 URL: https://issues.apache.org/jira/browse/JCR-863
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: query
>            Reporter: Michael Neale
>             Fix For: 1.4
>         Attachments: FSDirectory.patch, JCR-863.patch
> The FSDirectory uses File.createNewFile to effectively lock a directory (in makeLock),
yet the Java Spec says explcitly not to use it for this purpose, and instead use FileLock
from nio.
> The attached patch shows how this is/could be done (change is internal to the makeLock
method only, and functionally equivalent, the same tests apply).

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message