jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Reutegger (JIRA)" <j...@apache.org>
Subject [jira] Updated: (JCR-862) unsynchronized access on 'itemCache' map in ItemManager
Date Fri, 04 May 2007 08:46:15 GMT

     [ https://issues.apache.org/jira/browse/JCR-862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Marcel Reutegger updated JCR-862:
---------------------------------

    Attachment: ItemManager.patch

I suggest we use the Map itself as a monitor to synchronize access to the cache. The ItemManager
instance (this) is already used as a monitor to synchronize access from multiple threads using
the same session. I would rather get rid of those, but that's a different story.

> unsynchronized access on 'itemCache' map in ItemManager 
> --------------------------------------------------------
>
>                 Key: JCR-862
>                 URL: https://issues.apache.org/jira/browse/JCR-862
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.2.3
>            Reporter: Tobias Bocanegra
>         Assigned To: Stefan Guggisberg
>             Fix For: 1.4
>
>         Attachments: ItemManager.patch, stacktrace.txt
>
>
> the access 'itemCache' map in ItemManager is mostly synchronized by not via the ItemStateListener
methods:
> [...]
>     public void stateCreated(ItemState created) {
>         ItemImpl item = retrieveItem(created.getId());
>         if (item != null) {
>             item.stateCreated(created);
>         }
>     }
> [...]
>     private ItemImpl retrieveItem(ItemId id) {
>         return (ItemImpl) itemCache.get(id);
>     }
> [...]
> this can result in a corruption of a map (eg subsequent accesses may result in a endless
loop).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message