jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Neale (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-863) Patch to use FileLock for locking instead of empty file
Date Thu, 24 May 2007 06:25:16 GMT

    [ https://issues.apache.org/jira/browse/JCR-863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498501

Michael Neale commented on JCR-863:

Have looked into the other JIRA - on second look I am not sure if its a problem, as this uses
lock() not tryLock, which is fail fast and exclusive. A bigger problem is the issue of JRE
implementation on a given platform, not entirely sure how much this can be relied on.

Also, I remember hearing some talk about this being done entirely in Lucene (so this code
can be retired?) - then its Lucene's problem !

> Patch to use FileLock for locking instead of empty file
> -------------------------------------------------------
>                 Key: JCR-863
>                 URL: https://issues.apache.org/jira/browse/JCR-863
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: query
>            Reporter: Michael Neale
>             Fix For: 1.4
>         Attachments: FSDirectory.patch, JCR-863.patch
> The FSDirectory uses File.createNewFile to effectively lock a directory (in makeLock),
yet the Java Spec says explcitly not to use it for this purpose, and instead use FileLock
from nio.
> The attached patch shows how this is/could be done (change is internal to the makeLock
method only, and functionally equivalent, the same tests apply).

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message