Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Received-SPF: pass (hermes.apache.org: domain of harvey.waters@googlemail.com
 designates 66.249.92.170 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=googlemail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=gDanwkxCHJS3r1/MWJ2f4BKKIVHzG92E0vAJs/9ZGAIrQdVOypEMrqagKbxSwyKE11ff4u0ddNjaj4B0bL+jzc6fP1URWA8WyeaZV16YPZ8Mgki1yzHmDYFyA2GrqeJ46deJGvvnrPZQ9fNBy82rgffVtnvEP5AMICQbyENieDU=
Message-ID: <235bf4ca0703280106m7376f293ya598c867f27853c8@mail.gmail.com>
Date: Wed, 28 Mar 2007 09:06:51 +0100
From: "harvey waters" <harvey.waters@googlemail.com>
To: dev@jackrabbit.apache.org, tobias.bocanegra@day.com
Subject: Re: Restore throws a ConstraintViolationException
In-Reply-To: <8be731880703270533u3d6de2f4o2abb4f9ed3f62d43@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_8907_221831.1175069211389"
References: <9691232.post@talk.nabble.com>
	 <8be731880703270533u3d6de2f4o2abb4f9ed3f62d43@mail.gmail.com>

------=_Part_8907_221831.1175069211389
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi Tobias,

I've been running and re-running the code to try and understand this and I'm
sure this is a bug. setMixinTypesProperty does indeed alter the value of the
mixin type property but it doesn't change the mixinTypeNames in the state
variable (NodeState), this still has the original mixin names in it. When
the session.save is fired (at the end of the restore) the effective node
type uses  '((NodeState) state).getMixinTypeNames()' this builds an
effective node type that is now incorrect (as the restore has removed the
mandatory properties).

Thanks for the help.

Harvey

On 3/27/07, Tobias Bocanegra <tobias.bocanegra@day.com> wrote:
>
> yes, there is:
>
>         // adjust mixins
>         QName[] mixinNames = freeze.getFrozenMixinTypes();
>         setMixinTypesProperty(new HashSet(Arrays.asList(mixinNames)));
>
> regards, toby
>
> On 3/27/07, HarveyWaters <harvey.waters@googlemail.com> wrote:
> >
> > I can see in the restoreFrozen state function of NodeImpl that any
> properties
> > that are not in the node being restored are removed. There doesn't
> however
> > appear to be anything to remove mixinTypes that are no longer in the
> > restored node. Consequently a constraint violation is thrown for any
> mixin
> > types within mandatory properties. Is this right or am I missing
> something ?
> > --
> > View this message in context:
> http://www.nabble.com/Restore-throws-a-ConstraintViolationException-tf3472710.html#a9691232
> > Sent from the Jackrabbit - Dev mailing list archive at Nabble.com.
> >
> >
>
>
> --
> -----------------------------------------< tobias.bocanegra@day.com >---
> Tobias Bocanegra, Day Management AG, Barfuesserplatz 6, CH - 4001 Basel
> T +41 61 226 98 98, F +41 61 226 98 97
> -----------------------------------------------< http://www.day.com >---
>

------=_Part_8907_221831.1175069211389--