Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Received-SPF: pass (herse.apache.org: domain of stefan.guggisberg@gmail.com
 designates 66.249.92.173 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=hInM/6JkVTFeduvRTvpcAxnG8vKBTtfXLzzM7wdbCUiOHdrr2fYRANdjNqpvXslv0xin6jZMgPoyuzklqO/JbHmBEWOTz6jUTvLBx/BmJ4Ebs4LKfCD1KO2j55o9LVJG5i+bgXP/lIauyQ7aySHops1VaP6oM9G1bsC2WsBcF2Q=
Message-ID: <90a8d1c00702080058x1041264amc1940196492228e@mail.gmail.com>
Date: Thu, 8 Feb 2007 09:58:31 +0100
From: "Stefan Guggisberg" <stefan.guggisberg@gmail.com>
To: dev@jackrabbit.apache.org
Subject: Re: svn commit: r504623 -
 /jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/SessionImpl.java
In-Reply-To: <90a8d1c00702080044s8f3f8e0j47fdda296b2a86f8@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20070207172102.9EA741A981A@eris.apache.org>
	 <510143ac0702071105t4c96d890kbb126506520c228@mail.gmail.com>
	 <90a8d1c00702080044s8f3f8e0j47fdda296b2a86f8@mail.gmail.com>

On 2/8/07, Stefan Guggisberg <stefan.guggisberg@gmail.com> wrote:
> On 2/7/07, Jukka Zitting <jukka.zitting@gmail.com> wrote:
> > Hi,
> >
> > On 2/7/07, stefan@apache.org <stefan@apache.org> wrote:
> > >      public Node getNodeByUUID(UUID uuid) throws ItemNotFoundException, RepositoryException {
> > >          NodeImpl node = getNodeById(new NodeId(uuid));
> > > +        // since the uuid of a node is only exposed through jcr:uuid declared
> > > +        // by mix:referenceable it's rather unlikely that a client can possibly
> > > +        // know the internal uuid of a non-referenceable node; omitting the
> > > +        // check for mix:referenceable seems therefore to be a reasonable
> > > +        // compromise in order to improve performance.
> > > +/*
> > >          if (node.isNodeType(QName.MIX_REFERENCEABLE)) {
> > >              return node;
> > >          } else {
> > >              // there is a node with that uuid but the node does not expose it
> > >              throw new ItemNotFoundException(uuid.toString());
> > >          }
> > > +*/
> > > +        return node;
> > >      }
> >
> > Sounds reasonable, but I'm not convinced that the performance gain is
> > noticeable enough to justify the change. What's the access pattern
> > we're trying to speed up?
>
> well, applications that make *heavy* use of  Node.getNodeByUUID do

of course i meant Session.getNodeByUUID...

cheers
stefan

> benefit considerably as shown by our profiling data.
>
> cheers
> stefan
>
> >
> > BR,
> >
> > Jukka Zitting
> >
>