Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Received-SPF: pass (herse.apache.org: domain of savvas.triantafillou@gmail.com
 designates 66.249.92.169 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:mime-version:content-type;
        b=OKGkmWp2rA9IStdh7PjkE2k0l46Sbo6Y1CMS6no9yt+fBuLmfyMhg0M2AQdsLsv8Z8bJTx9EiHnYkl9KTNiIm6Bx9HiI74pplSxB1oXwYwPYyOVJfhWYE3K0DsEE8Qk6TQ07q0D+WuImhtQCBeaHB2mWCqu6yrbeLhOvOULrPko=
Message-ID: <f45b79310612081434k5908c224q1a732c9d442f6cce@mail.gmail.com>
Date: Sat, 9 Dec 2006 00:34:56 +0200
From: "Savas Triantafillou" <savvas.triantafillou@gmail.com>
To: dev@jackrabbit.apache.org
Subject: Missing (?) code in XAEnvironment class
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_43118_18303397.1165617296648"

------=_Part_43118_18303397.1165617296648
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi,

I'm using version 1.1.1  and I was trying to add a lockToken of an
open-scoped lock to an XASession but it seems to be ignored.

While debugging, I found out that XALockManager.lockTokenAdded redirects to
XAEnvironment.addLockToken which is ... empty!

I've notice that XAEnvironment.removeLockToken is empty too...


I have updated these methods as follows
 /**
     * Add lock token to this environment.
     * @param lt lock token
     */
    public void addLockToken(String lt) {
        lockMgr.lockTokenAdded(session, lt);
    }

    /**
     * Remove lock token from this environment.
     * @param lt lock token
     */
    public void removeLockToken(String lt) {
        lockMgr.lockTokenRemoved(session, lt);
    }

but I would like to know if there is more than one should do. For the moment
this seems to fix
the problem of adding and removing lock tokens but I have the sense that
there is more to do...


Thank you for your time,

Savvas

------=_Part_43118_18303397.1165617296648--