Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Message-ID: <33042994.1165852467784.JavaMail.jira@brutus>
Date: Mon, 11 Dec 2006 07:54:27 -0800 (PST)
From: "Jan Kuzniak (JIRA)" <jira@apache.org>
To: dev@jackrabbit.apache.org
Subject: [jira] Updated: (JCR-97) Improve Checkstyle conformance
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

     [ http://issues.apache.org/jira/browse/JCR-97?page=all ]

Jan Kuzniak updated JCR-97:
---------------------------

    Attachment: jackrabbit.core.cluster_imports.patch

Thank you, now I am starting to understand Jackrabbit desired code format guidelines better. It would be great to put them together on some page (e.g. wiki) or something, possibly along with a checkstyle and Eclipse formatter (that I am still adjusting to fit your suggestions). I see that it could be built incrementally and evolve into a code conventions specification document.

I decided to start this work over again. I will submit smaller and one aspect based patches right on. First, patch that organizes imports in jackrabbit.core.cluster package.

--
Regards,
 Jan

> Improve Checkstyle conformance
> ------------------------------
>
>                 Key: JCR-97
>                 URL: http://issues.apache.org/jira/browse/JCR-97
>             Project: Jackrabbit
>          Issue Type: Improvement
>            Reporter: Jukka Zitting
>            Priority: Minor
>         Attachments: jackrabbit.core.cluster_imports.patch, jackrabbit.core.jndi.patch, jackrabbit.core.lock.patch, jackrabbitAPICheckstylePatch.patch, jackrabbitCoreClusterCleanup.patch, jackrabbitCoreConfigCleanup.patch, jackrabbitCoreFsDbCleanup.patch, jackrabbitCoreFsDbCleanup.patch, jackrabbitCoreUnnecessaryCodeCleanup.patch
>
>
> This is an ongoing meta-issue for improving the Checkstyle conformance of the Jackrabbit codebase.
> Checkstyle (http://checkstyle.sourceforge.net/) is an automated tool for checking conformance with coding standard and good coding style. A Checkstyle report for Jackrabbit can be generated by running "maven checkstyle".
> Currently the Jackrabbit Checkstyle report contains thousands of trivial problems like unused imports and minor formatting issues. While it would be possible to just remove those checks from the Jackrabbit Checkstyle configuration, it would certainly be better to fix the real issues. After fixing the trivial problems, the Checkstyle reports become much more valuable tools in locating troublesome code and identifying chances for improvement.
> While this issue remains open, you have an open mandate to improve the standards conformance and coding style of the Jackrabbit sources. This mandate applies only to changes that fix problems reported by Checkstyle while making no changes to the external interface or behaviour of the changed code.
> The commit messages of such Checkstyle improvements should be labeled with the Jira key of this issue (JCR-97) to mark the changes as style-only. This way other committers will have easier time reviewing your changes for bugs or other unexpected side-effects.
> If you are not a Jackrabbit committer, but want to help improve the Checkstyle conformance, you can make your changes using sources from anonymous subversion and send your changes as an attachment to this issue. Please see the Javadoc improvement issue JCR-73 for details.
> PS. Blind conformance to style guides is seldom beneficial. Please remember that the goal of this issue is to improve Jackrabbit code, not just the Checkstyle output!

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira