Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 47408 invoked from network); 28 Dec 2006 09:57:44 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 28 Dec 2006 09:57:44 -0000 Received: (qmail 70697 invoked by uid 500); 28 Dec 2006 09:57:50 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 70663 invoked by uid 500); 28 Dec 2006 09:57:50 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 70654 invoked by uid 99); 28 Dec 2006 09:57:50 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Dec 2006 01:57:50 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Dec 2006 01:57:42 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 64EF17142B6 for ; Thu, 28 Dec 2006 01:57:22 -0800 (PST) Message-ID: <1253798.1167299842410.JavaMail.jira@brutus> Date: Thu, 28 Dec 2006 01:57:22 -0800 (PST) From: "Julian Reschke (JIRA)" To: dev@jackrabbit.apache.org Subject: [jira] Commented: (JCR-691) Let NameException extend RepositoryException In-Reply-To: <21446453.1167271880979.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ http://issues.apache.org/jira/browse/JCR-691?page=comments#action_12461168 ] Julian Reschke commented on JCR-691: ------------------------------------ I completely agree with this. Everytime I catch a NameException I wrap it into a RepositoryException. But this change may break some code, no? > Let NameException extend RepositoryException > -------------------------------------------- > > Key: JCR-691 > URL: http://issues.apache.org/jira/browse/JCR-691 > Project: Jackrabbit > Issue Type: Improvement > Components: core > Reporter: Jukka Zitting > Priority: Minor > Fix For: 1.3 > > Attachments: NameException.patch > > > Since the NameExceptions (IllegalNameException, UnknownPrefixException, etc.) are typically thrown when parsing or formatting JCR names at the JCR API level, it would make sense for the NameException class to extend RepositoryException instead of the internal BaseException. This idea is supported by the fact that the majority of cases where NameExceptions are encountered simply rethrow the exceptions wrapped inside RepositoryException instances. Making NameException extend RepositoryException would reduce the amount of try-catch blocks and wrapped exceptions. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira