Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 26790 invoked from network); 5 Dec 2006 15:09:46 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 5 Dec 2006 15:09:46 -0000 Received: (qmail 99725 invoked by uid 500); 5 Dec 2006 15:09:53 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 99699 invoked by uid 500); 5 Dec 2006 15:09:53 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 99686 invoked by uid 99); 5 Dec 2006 15:09:53 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Dec 2006 07:09:52 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Dec 2006 07:09:44 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 5B3EA7142D7 for ; Tue, 5 Dec 2006 07:09:22 -0800 (PST) Message-ID: <1188250.1165331362369.JavaMail.jira@brutus> Date: Tue, 5 Dec 2006 07:09:22 -0800 (PST) From: "Marcel Reutegger (JIRA)" To: dev@jackrabbit.apache.org Subject: [jira] Commented: (JCR-664) Property.setValue(Node) explicitly checks for NodeImpl In-Reply-To: <4196228.1165329741051.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ http://issues.apache.org/jira/browse/JCR-664?page=comments#action_12455662 ] Marcel Reutegger commented on JCR-664: -------------------------------------- Shouldn't a decoration layer un-wrap a Node instance in the first place when it passes it to the decorated repository? > Property.setValue(Node) explicitly checks for NodeImpl > ------------------------------------------------------ > > Key: JCR-664 > URL: http://issues.apache.org/jira/browse/JCR-664 > Project: Jackrabbit > Issue Type: Bug > Reporter: Tobias Bocanegra > > The implementation of Propert.setValue(Node) explicitly checks if the argument is a NodeImpl: > if (target instanceof NodeImpl) { > [...] > } else { > String msg = "incompatible Node object: " + target; > log.debug(msg); > throw new RepositoryException(msg); > } > This is not very convenient for applications that decorate the jcr objects. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira