jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Guggisberg (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-680) Improve the Value implementation
Date Fri, 22 Dec 2006 11:31:25 GMT
    [ http://issues.apache.org/jira/browse/JCR-680?page=comments#action_12460441 ] 
            
Stefan Guggisberg commented on JCR-680:
---------------------------------------

> * Support for namespace remappings in NAME and PATH values 

is this a requirement? IMO the spec doesn't mandate it. 

a first rough run through the (btw huge!) patch revealed 2 issues:

- SerializableInputStream: 
  the stream data is materialized in memory during de-/serialization;
  this renders it imo unusable for large streams. in the entire core
  streams are never unconditionally materialized. 

- ValueParser:
   the getDate() method does not preserve the time zone in the 
   returned Calendar object. the current implementation internally
   uses to ISO8601 utilty class which preserves the time zone  
   information. what was the rationale of not using the ISO8601 class?



> Improve the Value implementation
> --------------------------------
>
>                 Key: JCR-680
>                 URL: http://issues.apache.org/jira/browse/JCR-680
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: core
>            Reporter: Jukka Zitting
>         Assigned To: Jukka Zitting
>            Priority: Minor
>         Attachments: class.jpg, JCR-680.patch
>
>
> The current Value implementation found in jackrabbit-jcr-commons has some deficiencies
like Value.equals() being incorrect in some cases (see for example JCR-320), and Name and
Path values not following namespace remappings.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message