jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Julian Reschke (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-691) Let NameException extend RepositoryException
Date Thu, 28 Dec 2006 09:57:22 GMT
    [ http://issues.apache.org/jira/browse/JCR-691?page=comments#action_12461168 ] 
            
Julian Reschke commented on JCR-691:
------------------------------------

I completely agree with this. Everytime I catch a NameException I wrap it into a RepositoryException.

But this change may break some code, no?


> Let NameException extend RepositoryException
> --------------------------------------------
>
>                 Key: JCR-691
>                 URL: http://issues.apache.org/jira/browse/JCR-691
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: core
>            Reporter: Jukka Zitting
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: NameException.patch
>
>
> Since the NameExceptions (IllegalNameException, UnknownPrefixException, etc.) are typically
thrown when parsing or formatting JCR names at the JCR API level, it would make sense for
the NameException class to extend RepositoryException instead of the internal BaseException.
This idea is supported by the fact that the majority of cases where NameExceptions are encountered
simply rethrow the exceptions wrapped inside RepositoryException instances. Making NameException
extend RepositoryException would reduce the amount of try-catch blocks and wrapped exceptions.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message