Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 9397 invoked from network); 22 Nov 2006 14:49:30 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 22 Nov 2006 14:49:30 -0000 Received: (qmail 89546 invoked by uid 500); 22 Nov 2006 14:49:38 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 89518 invoked by uid 500); 22 Nov 2006 14:49:38 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 89509 invoked by uid 99); 22 Nov 2006 14:49:38 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Nov 2006 06:49:38 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of jukka.zitting@gmail.com designates 64.233.184.224 as permitted sender) Received: from [64.233.184.224] (HELO wr-out-0506.google.com) (64.233.184.224) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Nov 2006 06:49:25 -0800 Received: by wr-out-0506.google.com with SMTP id i22so35988wra for ; Wed, 22 Nov 2006 06:49:05 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=iDjE8No35XgjyEcaYGVyhzzr948MpLvRKxK8pXAbzhk4qFGItoiM//txZ4F6d2r06iGw3FBnT6X8xbAA1E6FGjkqIFOxNoJAX6/majvAusCF/5hhTgTmHfEgxkYdpmlAtDT0AUbfTgk8z1+D70WF8w+bb40V+XgEVcH6RRsGoJ4= Received: by 10.90.90.16 with SMTP id n16mr6669318agb.1164206945076; Wed, 22 Nov 2006 06:49:05 -0800 (PST) Received: by 10.90.102.20 with HTTP; Wed, 22 Nov 2006 06:49:04 -0800 (PST) Message-ID: <510143ac0611220649o431a9fd6va969d397c838f4e1@mail.gmail.com> Date: Wed, 22 Nov 2006 16:49:04 +0200 From: "Jukka Zitting" To: dev@jackrabbit.apache.org Subject: Re: SPI: PropertyDefinition.getRequiredType In-Reply-To: <45645DC7.5040107@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <45644AD3.8000104@gmx.de> <45645A6C.2010602@day.com> <45645DC7.5040107@gmx.de> X-Virus-Checked: Checked by ClamAV on apache.org Hi, On 11/22/06, Julian Reschke wrote: > No, the point is that in JSR-170 it is possible that for a given node > type N, the NodeType interface will only return residual property > definitions (because the set of property definitions on this node type > may be very large), while Property.getPropertyDefinition() will return a > non-residual definition (because in this case, the property name is > known in advance, so the size problem above doesn't matter). Are you sure this is OK? At least it breaks the following symmetry: PropertyDefinition definition = property.getDefinition(); NodeType type = definition.getDeclaringNodeType(); assert Arrays.asList(type.getDeclaredPropertyDefinitions()).contains(definition); I would return the residual node definition from Property.getDefinition() unless the underlying more specific definition has been explicitly exposed through the NodeType API. BR, Jukka Zitting