Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 47394 invoked from network); 3 Nov 2006 10:15:58 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Nov 2006 10:15:58 -0000 Received: (qmail 42729 invoked by uid 500); 3 Nov 2006 10:16:09 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 42329 invoked by uid 500); 3 Nov 2006 10:16:07 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 42319 invoked by uid 99); 3 Nov 2006 10:16:07 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Nov 2006 02:16:07 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Nov 2006 02:15:55 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id A49417142F9 for ; Fri, 3 Nov 2006 02:15:17 -0800 (PST) Message-ID: <30660062.1162548917671.JavaMail.root@brutus> Date: Fri, 3 Nov 2006 02:15:17 -0800 (PST) From: "Tobias Bocanegra (JIRA)" To: dev@jackrabbit.apache.org Subject: [jira] Closed: (JCR-618) Replace WeakIdentityCollection in StateChangeDispacher In-Reply-To: <32407102.1162546336580.JavaMail.root@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ http://issues.apache.org/jira/browse/JCR-618?page=all ] Tobias Bocanegra closed JCR-618. -------------------------------- Resolution: Fixed Committed revision 470747. > Replace WeakIdentityCollection in StateChangeDispacher > ------------------------------------------------------ > > Key: JCR-618 > URL: http://issues.apache.org/jira/browse/JCR-618 > Project: Jackrabbit > Issue Type: Improvement > Affects Versions: 1.1 > Reporter: Tobias Bocanegra > Assigned To: Tobias Bocanegra > Fix For: 1.2 > > > As a leftover from event refactoring, the listeners in the StateChangeDispatcher are still > managed by a WeakIdentityCollection and for every notify event, it's synchronized and copied > into an array. this is very expensive and unnecessary. > since the addition and removal of listeners is now controlled, and listeners can't just disappear, > it possible to use a normal collection. > Suggest to replace the WeakIdentityCollection by a > 'EDU.oswego.cs.dl.util.concurrent.CopyOnWriteArrayList' that allows read access (and iteration) > without synchronization. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira