Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Message-ID: <12384287.1162083558334.JavaMail.root@brutus>
Date: Sat, 28 Oct 2006 17:59:18 -0700 (PDT)
From: "Edgar Poce (JIRA)" <jira@apache.org>
To: dev@jackrabbit.apache.org
Subject: [jira] Commented: (JCR-593) JCASessionHandle fail when i invoke
 logout method
In-Reply-To: <2697336.1160987615001.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

    [ http://issues.apache.org/jira/browse/JCR-593?page=3Dcomments#action_1=
2445422 ]=20
           =20
Edgar Poce commented on JCR-593:
--------------------------------

I think the jca project is not handling the close method  properly because =
there shouldn't be a bind to transaction configuration option. The jca proj=
ect should bind the jcr session to the transaction only if a logout call wa=
s made inside a transaction.  WDYT?
I'll prepare a patch asap.

I don't think the proposed patch is a good fix. With the proposed patch if =
the client doesn't participate in a transaction when it tries to close the =
session the call will be ignored causing a session leak.

In the current revision the jcr session is bound to the transaction lifecyc=
le *optionally*. If the jcr module closes the session you can set the optio=
n to false and it should work fine for you.

thanks


> JCASessionHandle fail when i invoke logout method
> -------------------------------------------------
>
>                 Key: JCR-593
>                 URL: http://issues.apache.org/jira/browse/JCR-593
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jca
>    Affects Versions: 1.0.1, 1.1
>            Reporter: Jorge Rodr=C3=ADguez Pedrianes
>
> I think that the "logout method" (in JCASessionHandle) isn't totally corr=
ect. I consider that we must check, before closing session, if this session=
 is binded to a transaction. In this situation the session mustn't be close=
d: transaction will close it.
>     public void logout() {
>           if (!mc.getManagedConnectionFactory().getBindSessionToTrasactio=
n().booleanValue()) {
>                mc.closeHandle(this);
>           }
>     }
> For example this is very important when we use spring, springmodules (jcr=
 module) and jackrabbit because the springmodules library closes session wh=
en local transaction finishes. And if the session is closed by transaction =
a exception is throwed.
> Thanks

--=20
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: htt=
p://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira