jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jukka Zitting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-595) Refactoring of the Persistence Managers
Date Tue, 31 Oct 2006 17:32:17 GMT
    [ http://issues.apache.org/jira/browse/JCR-595?page=comments#action_12445968 ] 
Jukka Zitting commented on JCR-595:

The "unknown schema" problem should now really be fixed as of revision 469571.

The compatibility classes in o.a.j.core.state.db used to override the getClass().getResourceAsStream()
call with super.getClass().getResourceAsStream(), so my fix with DatabasePersistenceManager.class.getResourceAsStream()
didn't have any effect on the compatibility classes.

While the super.getClass() approach is intuitive, it's actually incorrect since super.getClass()
is exactly the same as this.getClass() as long as the getClass() method is not overridden.
So even if the subclasses attempted to avoid this problem, they actually ended up masking
the real solution. The change in revision 469571 removes these workarounds, so that my original
fix actually works.

> Refactoring of the Persistence Managers
> ---------------------------------------
>                 Key: JCR-595
>                 URL: http://issues.apache.org/jira/browse/JCR-595
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: core
>            Reporter: Tobias Bocanegra
>         Assigned To: Tobias Bocanegra
>            Priority: Minor
>             Fix For: 1.2
>         Attachments: jackrabbit.465518.patch
> currently the persistence managers reside in:
>  org.apache.jackrabbit.core.state
>  org.apache.jackrabbit.core.state.db
>  org.apache.jackrabbit.core.state.mem
>  org.apache.jackrabbit.core.state.obj
>  org.apache.jackrabbit.core.state.xml
>  (org.apache.jackrabbit.core.state.util)
> there are also a lot of other classes that deal with states (eg:
> SharedItemStateManager) in the state package that do not relate to
> pms.
> i would like to move all persistencemanagers and pm related stuff to:
>  org.apache.jackrabbit.core.persistence
> I'd keep the current classes as deprecated subclasses within
> jackrabbit-core.jar until Jackrabbit 2.0. There may (?) be people who
> are extending the existing classes, so I'd avoid breaking binary
> compatibility there even though we've never promised to actually honor
> compatiblity within o.a.j.core.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message