jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (JIRA)" <j...@apache.org>
Subject [jira] Updated: (JCR-583) TCK: NodeReadMethodsTest.testGetName fails with NPE if 'testroot' has no child node
Date Tue, 03 Oct 2006 15:12:20 GMT
     [ http://issues.apache.org/jira/browse/JCR-583?page=all ]

angela updated JCR-583:
-----------------------

    Attachment: NodeReadMethodsTest.patch

patch for this issue.

btw: 'testGetName'  initially tests if the root node's name is "".  This is already covered
by RootNodeTest.testGetName and i would rather not mix this into the 'testGetName' case, which
states in the JavaDoc, that  the last segment of the path and the name are being compared.
For this reason i removed the additional test for the root node in the patch.

> TCK: NodeReadMethodsTest.testGetName fails with NPE if  'testroot' has no child node
> ------------------------------------------------------------------------------------
>
>                 Key: JCR-583
>                 URL: http://issues.apache.org/jira/browse/JCR-583
>             Project: Jackrabbit
>          Issue Type: Bug
>            Reporter: angela
>            Priority: Trivial
>         Attachments: NodeReadMethodsTest.patch
>
>
> The 'testGetName' does not assert, that  the childnode field has been populated during
setup.
> if  for whatever reason  the test data don't provide a single childnode below the test
root, this test will fail with nullpointer
> exception.
> i would like to suggest to use the same assertion as in testGetPath and throw a NotExecutableException
in case of
> missing child node.
> patch attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message