Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 44858 invoked from network); 5 Sep 2006 10:05:39 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 5 Sep 2006 10:05:38 -0000 Received: (qmail 87774 invoked by uid 500); 5 Sep 2006 10:05:37 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 87747 invoked by uid 500); 5 Sep 2006 10:05:36 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 87738 invoked by uid 99); 5 Sep 2006 10:05:36 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Sep 2006 03:05:36 -0700 X-ASF-Spam-Status: No, hits=0.5 required=10.0 tests=DNS_FROM_RFC_ABUSE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of jukka.zitting@gmail.com designates 66.249.82.239 as permitted sender) Received: from [66.249.82.239] (HELO wx-out-0506.google.com) (66.249.82.239) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Sep 2006 03:05:34 -0700 Received: by wx-out-0506.google.com with SMTP id t13so2330750wxc for ; Tue, 05 Sep 2006 03:05:14 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=lIEbOMgl8Zz6eqYK/23VOg70nh46zo5Cp+7RwLIrFKi2wVWJkP6bHClIPr5nbLdaMA+Ey3N0xOHhlVsvZ679mXAvzFHZWmXqcjnuoUIPDvwmtarkZCK+Elo0vk7gbWEsTEHqPJcUR9AoD/yVb9coaDgBlb2onKzff/yetQ1luGs= Received: by 10.90.100.2 with SMTP id x2mr1234735agb; Tue, 05 Sep 2006 03:05:14 -0700 (PDT) Received: by 10.90.96.17 with HTTP; Tue, 5 Sep 2006 03:05:13 -0700 (PDT) Message-ID: <510143ac0609050305g1eca9d00i23bee3dcd26279ee@mail.gmail.com> Date: Tue, 5 Sep 2006 13:05:13 +0300 From: "Jukka Zitting" To: dev@jackrabbit.apache.org Subject: Re: Refactoring of the backupTool In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <510143ac0609020855x64b18fa1n74426338fd53d3c1@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Hi, On 9/4/06, Nicolas wrote: > I am following our IM chat where you explained me a few things I didn't > understand at first. I will summarize it here on the ML. Thanks! > - Actually between RestoreBatchedItemOperations and BatchedItemOperations, I > only have deleted the "recursively add 'auto-create' child nodes defined in > node type" part. This way, I only create node. This way we only create node > and so don't check for protection (since a node to be created is not yet > protected :p). I could add some composition to this, but only to this part > seems overkill. I don't really see what I can do on this. What do you think? If it's just a single feature then adding a flag for enabling/disabling it could also solve the need. > - NodeVersionHistoriesUpdatableStateManager and UpdatableStateItemManager. > Actually, I created one new UISM because I couldn't understand how the > EventStateCollectionFactory worked (I tried null and to instantiate one but > it didn't work), therefore couldn't reuse the LocalItemStateManager. If > someone can explain it to me, I might be able to delete this class. The ESCF is used for sending observation events. For example the VersionManagerImpl contains the escFactory instance that you should be able to use. BR, Jukka Zitting -- Yukatan - http://yukatan.fi/ - info@yukatan.fi Software craftsmanship, JCR consulting, and Java development