Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Message-ID: <20971576.1158409943126.JavaMail.jira@brutus>
Date: Sat, 16 Sep 2006 05:32:23 -0700 (PDT)
From: "Jukka Zitting (JIRA)" <jira@apache.org>
To: dev@jackrabbit.apache.org
Subject: [jira] Resolved: (JCR-565) Refactor ObservationManagerFactory
In-Reply-To: <1886373.1157960002255.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

     [ http://issues.apache.org/jira/browse/JCR-565?page=all ]

Jukka Zitting resolved JCR-565.
-------------------------------

    Fix Version/s: 1.1
       Resolution: Fixed
         Assignee: Jukka Zitting

Suggested changes applied in revision 446866.

> Refactor ObservationManagerFactory
> ----------------------------------
>
>                 Key: JCR-565
>                 URL: http://issues.apache.org/jira/browse/JCR-565
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: observation
>            Reporter: Jukka Zitting
>         Assigned To: Jukka Zitting
>            Priority: Minor
>             Fix For: 1.1
>
>         Attachments: dispatcher.patch
>
>
> The current o.a.j.core.observation.ObservationManagerFactory class has two main responsibilities:
>     1) Create new ObservationManagerImpl instances as an observation manager factory
>     2) Manage event consumers and dispatch events within a workspace
> These two responsibilities are quite unrelated and the factory responsibility essentially boils down to the following method that is only ever invoked within WorkspaceImpl.getObservationManager():
>     public ObservationManagerImpl createObservationManager(SessionImpl session, ItemManager itemMgr) {
>         return new ObservationManagerImpl(this, session, itemMgr);
>     }
> To simplify the design I'd inline this method and rename ObservationManagerFactory to ObservationDispatcher to better reflect the one remaining responsibility.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira