jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jukka Zitting (JIRA)" <j...@apache.org>
Subject [jira] Updated: (JCR-565) Refactor ObservationManagerFactory
Date Mon, 11 Sep 2006 07:37:22 GMT
     [ http://issues.apache.org/jira/browse/JCR-565?page=all ]

Jukka Zitting updated JCR-565:

    Attachment: dispatcher.patch

Attached a patch that performs this refactoring. I'll apply it unless anyone objects within
a few days.

> Refactor ObservationManagerFactory
> ----------------------------------
>                 Key: JCR-565
>                 URL: http://issues.apache.org/jira/browse/JCR-565
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: observation
>            Reporter: Jukka Zitting
>            Priority: Minor
>         Attachments: dispatcher.patch
> The current o.a.j.core.observation.ObservationManagerFactory class has two main responsibilities:
>     1) Create new ObservationManagerImpl instances as an observation manager factory
>     2) Manage event consumers and dispatch events within a workspace
> These two responsibilities are quite unrelated and the factory responsibility essentially
boils down to the following method that is only ever invoked within WorkspaceImpl.getObservationManager():
>     public ObservationManagerImpl createObservationManager(SessionImpl session, ItemManager
itemMgr) {
>         return new ObservationManagerImpl(this, session, itemMgr);
>     }
> To simplify the design I'd inline this method and rename ObservationManagerFactory to
ObservationDispatcher to better reflect the one remaining responsibility.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message