Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 8241 invoked from network); 17 Aug 2006 21:29:51 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 17 Aug 2006 21:29:51 -0000 Received: (qmail 36602 invoked by uid 500); 17 Aug 2006 21:29:46 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 36533 invoked by uid 500); 17 Aug 2006 21:29:46 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 36504 invoked by uid 99); 17 Aug 2006 21:29:46 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Aug 2006 14:29:46 -0700 X-ASF-Spam-Status: No, hits=0.9 required=10.0 tests=HTML_10_20,HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of davek@us.ibm.com designates 32.97.182.141 as permitted sender) Received: from [32.97.182.141] (HELO e1.ny.us.ibm.com) (32.97.182.141) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Aug 2006 14:29:45 -0700 Received: from westrelay02.boulder.ibm.com (westrelay02.boulder.ibm.com [9.17.195.11]) by e1.ny.us.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id k7HLTOvZ024308 for ; Thu, 17 Aug 2006 17:29:24 -0400 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by westrelay02.boulder.ibm.com (8.13.6/8.13.6/NCO v8.1.1) with ESMTP id k7HLT388336226 for ; Thu, 17 Aug 2006 15:29:03 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id k7HLT39n019694 for ; Thu, 17 Aug 2006 15:29:03 -0600 Received: from d03nm119.boulder.ibm.com (d03nm119.boulder.ibm.com [9.17.195.145]) by d03av03.boulder.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id k7HLT3bM019686 for ; Thu, 17 Aug 2006 15:29:03 -0600 To: dev@jackrabbit.apache.org MIME-Version: 1.0 Subject: Multi-version restore withWebDAV VersionControlledItemCollection.update X-Mailer: Lotus Notes Release 7.0 HF144 February 01, 2006 From: David Kennedy Message-ID: Date: Thu, 17 Aug 2006 17:29:02 -0400 X-MIMETrack: Serialize by Router on D03NM119/03/M/IBM(Release 7.0.1HF269 | June 22, 2006) at 08/17/2006 15:29:03, Serialize complete at 08/17/2006 15:29:03 Content-Type: multipart/alternative; boundary="=_alternative 007601AA852571CD_=" X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N --=_alternative 007601AA852571CD_= Content-Type: text/plain; charset="US-ASCII" The WebDAV multi-version restore code in VersionControlledItemCollection.update method is suspicious. The code is trying to restore by label or by name. If multiple version hrefs are supplied or if multiple labels are supplied, the code will use the multi-version restore method of Workspace. The problem is that the versions are all retrieved for the same node and you can't have more than one version of the same node in a workspace. The multi-version restore method is intended for cross node dependencies. To enable the multi-version restore the body needs to support fully qualified version name and labels. You could argue that the version href already does so, however you'd assume the name is the version label and what's preceding it would be the itemPath (currently thrown out) to the actual node. However this would be a bit of a hack. It seems as though the body structure needs to change a bit to truly support multi-version restore. David --=_alternative 007601AA852571CD_=--