jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Pitfield (JIRA)" <j...@apache.org>
Subject [jira] Closed: (JCR-503) TCK: SetValueDateTest compares Calendar objects
Date Fri, 04 Aug 2006 19:55:20 GMT
     [ http://issues.apache.org/jira/browse/JCR-503?page=all ]

David Pitfield closed JCR-503.
------------------------------


> TCK: SetValueDateTest compares Calendar objects
> -----------------------------------------------
>
>                 Key: JCR-503
>                 URL: http://issues.apache.org/jira/browse/JCR-503
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: test
>            Reporter: David Pitfield
>             Fix For: 1.1
>
>
> SetValueDateTest#testDateSession
> SetValueDateTest#testDateParent
> Tests compare Calendar objects.  Calendar.equals(Object) is a stronger test than JSR-170
specifies for Value.equals(Object), leading to false failures.  For the purpose of these tests,
even Value.equals(Object) is too strong an equality test, since some repositories may normalize
date/time values across a save/read roundtrip (for example, converting "Z" to "+00:00", or
adding/removing trailing zeros in fractional seconds).
> Proposal: compare the getTimeInMillis() values.
> --- SetValueDateTest.java       (revision 422074)
> +++ SetValueDateTest.java       (working copy)
> @@ -79,7 +80,8 @@
>      public void testDateSession() throws RepositoryException {
>          property1.setValue(value);
>          superuser.save();
> -        assertEquals("Date node property not saved", value.getDate(), property1.getValue().getDate());
> +        assertEquals("Date node property not saved",
> +          value.getDate().getTimeInMillis(), property1.getDate().getTimeInMillis());
>      }
>   
>      /**
> @@ -89,7 +91,8 @@
>      public void testDateParent() throws RepositoryException {
>          property1.setValue(value.getDate());
>          node.save();
> -        assertEquals("Date node property not saved", value.getDate(), property1.getValue().getDate());
> +        assertEquals("Date node property not saved",
> +          value.getDate().getTimeInMillis(), property1.getDate().getTimeInMillis());
>      }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message