From dev-return-8066-apmail-jackrabbit-dev-archive=jackrabbit.apache.org@jackrabbit.apache.org Wed Jul 26 23:34:38 2006 Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 77093 invoked from network); 26 Jul 2006 23:34:38 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 26 Jul 2006 23:34:38 -0000 Received: (qmail 13282 invoked by uid 500); 26 Jul 2006 23:34:37 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 12922 invoked by uid 500); 26 Jul 2006 23:34:36 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 12913 invoked by uid 99); 26 Jul 2006 23:34:36 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Jul 2006 16:34:36 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Jul 2006 16:34:35 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id E69F041000A for ; Wed, 26 Jul 2006 23:32:13 +0000 (GMT) Message-ID: <3263958.1153956733941.JavaMail.jira@brutus> Date: Wed, 26 Jul 2006 16:32:13 -0700 (PDT) From: "David Pitfield (JIRA)" To: dev@jackrabbit.apache.org Subject: [jira] Created: (JCR-507) TCK: NodeTest#testMixinTypesProtected incorrectly fails MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N TCK: NodeTest#testMixinTypesProtected incorrectly fails ------------------------------------------------------- Key: JCR-507 URL: http://issues.apache.org/jira/browse/JCR-507 Project: Jackrabbit Issue Type: Bug Components: test Reporter: David Pitfield The test calls addMixin to add mix:referenceable to a node. This step is not required to test that jcr:mixinTypes is protected, yet may fail if the node is already mix:referenceable or cannot be mix:referenceable. Proposal: remove the call to addMixin. The test attempts to set jcr:mixinTypes to a scalar value, but reports a failure if the implementation throws ValueFormatException instead of ConstraintViolationException. Proposal: set jcr:mixinTypes to an array of length 1. --- NodeTest.java (revision 422074) +++ NodeTest.java (working copy) @@ -1130,10 +1142,9 @@ Node defaultRootNode = (Node) superuser.getItem(testRootNode.getPath()); Node testNode = defaultRootNode.addNode(nodeName1, testNodeType); - testNode.addMixin(mixReferenceable); try { - testNode.setProperty(jcrMixinTypes,mixLockable); + testNode.setProperty(jcrMixinTypes, new String[] { mixLockable }); fail("Manually setting jcr:mixinTypes should throw a ConstraintViolationException"); } catch (ConstraintViolationException success) { -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira