jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jukka Zitting (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (JCR-299) errors in text filters can cause indexing to fail without warning the client
Date Wed, 19 Jul 2006 18:05:15 GMT
     [ http://issues.apache.org/jira/browse/JCR-299?page=all ]

Jukka Zitting resolved JCR-299.
-------------------------------

    Resolution: Fixed
      Assignee: Jukka Zitting

Fixed in revision 423547 by catching and logging all index filter exceptions (even unchecked
ones). After considering this issue I don't think it makes sense to give the index filters
veto powers over saving content. They are not validators, so if a binary property cannot be
parsed for text content because of a file format error or some similar problem, the indexer
should return an empty reader instead of trying to revert the save or somehow signal the client
application.

The requested functionality would be better implemented by extending the value constraint
support in Jackrabbit. Please file a separate feature request if you still need this functionality.

> errors in text filters can cause indexing to fail without warning the client
> ----------------------------------------------------------------------------
>
>                 Key: JCR-299
>                 URL: http://issues.apache.org/jira/browse/JCR-299
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: indexing
>    Affects Versions: 1.0, 1.0.1, 0.9
>            Reporter: Brian Moseley
>         Assigned To: Jukka Zitting
>            Priority: Minor
>             Fix For: 1.1
>
>
> i've opened this issue to track the discussion at <http://thread.gmane.org/gmane.comp.apache.jackrabbit.devel/5086>.
briefly, exceptions thrown by text filters are logged and swallowed by jackrabbit; there's
no way for a text filter to signal to the jcr client that indexing failed.
> some solutions have been proposed, including throwing an unchecked exception, which doesn't
allow jackrabbit to maintain transactional integrity, and giving filters veto power over the
observed repository operation. depending on the difficulty of the solution that is eventually
determined to be correct, it may be sufficient for 1.0 to document the issue and perhaps improve
the warning/error logging.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message