jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tobias Bocanegra (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-476) Remove recently added getJCRPath()/getQPath() from NamespaceResolver
Date Thu, 13 Jul 2006 08:12:30 GMT
    [ http://issues.apache.org/jira/browse/JCR-476?page=comments#action_12420814 ] 

Tobias Bocanegra commented on JCR-476:
--------------------------------------

i totally agree to remove all QName/Path methods from NamespaceResolver. But moving the caching
caps to NameFormat might not be optimal, since it resides in commons and should be as indepdentant
from the core as possible (otherwise we would also need to rename all NameFormat.format()
to NameFormat.getInstance().format() ....)

however, my idea was to have a new interface 'QNameCache' that has simple caching methods.
if a namespace resolver implements this interface, NameFormat uses it's cache:

if (resolver instanceof QNameCache) {
  // check cache, etc....
}

> Remove recently added getJCRPath()/getQPath() from NamespaceResolver
> --------------------------------------------------------------------
>
>          Key: JCR-476
>          URL: http://issues.apache.org/jira/browse/JCR-476
>      Project: Jackrabbit
>         Type: Improvement

>     Versions: 1.1
>     Reporter: Tobias Bocanegra
>     Assignee: Tobias Bocanegra
>     Priority: Minor

>
> issue JCR-473 added 2 new methods to NamespaceResolver: 
>     public Path getQPath(String jcrPath) throws MalformedPathException;
>     public String getJCRPath(Path qPath) throws NoPrefixDeclaredException;
> which do not belong here, since the NamespaceResolver has nothing to do with paths. suggest
to remove them.
> further is the naming of the QName related methods a bit vague. suggest to rename them
to:
>    QName parseName(String jcrName)
>    String formatName(QName qName)
> (although they do not belong here either, but helps to leverage evt. caching namespace
resolvers).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message